dograh/api/tasks/campaign_tasks.py
Abhishek 6827744327
fix: make campaign process batch thread safe (#141)
* fix: dont schedule new batch on resume

* fix: make process_batch thread safe
2026-01-30 14:48:00 +05:30

155 lines
5.4 KiB
Python

from datetime import UTC, datetime
from typing import Dict
from loguru import logger
from api.db import db_client
from api.services.campaign.campaign_call_dispatcher import campaign_call_dispatcher
from api.services.campaign.campaign_event_publisher import (
get_campaign_event_publisher,
)
from api.services.campaign.errors import ConcurrentSlotAcquisitionError
from api.services.campaign.source_sync_factory import get_sync_service
async def sync_campaign_source(ctx: Dict, campaign_id: int) -> None:
"""
Phase 1: Syncs data from configured source to queued_runs table
- Campaign state should already be 'syncing'
- Determines source type from campaign configuration
- Fetches data via appropriate sync service (Google Sheets, HubSpot, etc.)
- Creates queued_run entries with unique source_uuid
- Updates campaign total_rows
- Transitions campaign state to 'running' on success
- Enqueues process_campaign_batch tasks
"""
logger.info(f"Starting source sync for campaign {campaign_id}")
try:
# Get campaign
campaign = await db_client.get_campaign_by_id(campaign_id)
if not campaign:
raise ValueError(f"Campaign {campaign_id} not found")
# Get appropriate sync service
sync_service = get_sync_service(campaign.source_type)
# Sync source data
rows_synced = await sync_service.sync_source_data(campaign_id)
if rows_synced == 0:
# No data to process
await db_client.update_campaign(
campaign_id=campaign_id,
state="completed",
completed_at=datetime.now(UTC),
source_sync_status="completed",
source_last_synced_at=datetime.now(UTC),
)
logger.info(f"Campaign {campaign_id} completed with no data to process")
return
# Update campaign state to running
await db_client.update_campaign(
campaign_id=campaign_id,
state="running",
source_sync_status="completed",
source_last_synced_at=datetime.now(UTC),
)
# Publish sync completed event - orchestrator will schedule first batch
publisher = await get_campaign_event_publisher()
await publisher.publish_sync_completed(
campaign_id=campaign_id,
total_rows=rows_synced,
source_type=campaign.source_type,
source_id=campaign.source_id,
)
logger.info(
f"Campaign {campaign_id} source sync completed, {rows_synced} rows synced"
)
except Exception as e:
logger.error(f"Error syncing campaign {campaign_id} source: {e}")
# Update campaign with error
await db_client.update_campaign(
campaign_id=campaign_id,
state="failed",
source_sync_status="failed",
source_sync_error=str(e),
)
raise
async def process_campaign_batch(
ctx: Dict, campaign_id: int, batch_size: int = 10
) -> None:
"""
Phase 2: Processes a batch of queued runs
- Fetches next batch of 'queued' runs (including due retries)
- Creates workflow runs with context variables
- Initiates Twilio calls with rate limiting
- Updates queued_run state to 'processed'
- Updates campaign.processed_rows counter
- Publishes batch_completed event for orchestrator
# TODO: May be not fail the campaign immediately on a single batch failure
# and propagate the error to campaign orchestrator which can fail the campaign
# on some consecutive batch failures.
"""
logger.info(f"Processing batch for campaign {campaign_id}, batch_size={batch_size}")
failed_count = 0
try:
# Process the batch
processed_count = await campaign_call_dispatcher.process_batch(
campaign_id=campaign_id, batch_size=batch_size
)
# Publish batch completed event - orchestrator will handle next batch scheduling
publisher = await get_campaign_event_publisher()
await publisher.publish_batch_completed(
campaign_id=campaign_id,
processed_count=processed_count,
failed_count=failed_count,
batch_size=batch_size,
)
logger.info(
f"Campaign {campaign_id} batch completed: processed={processed_count}, "
f"failed={failed_count}"
)
except ConcurrentSlotAcquisitionError as e:
logger.warning(
f"Failed to acquire concurrent slot for campaign {campaign_id}: {e}"
)
# Publish batch failed event with specific error
publisher = await get_campaign_event_publisher()
await publisher.publish_batch_failed(
campaign_id=campaign_id,
error=f"Concurrent slot acquisition timeout: {e}",
processed_count=0,
)
# Update campaign state to failed
await db_client.update_campaign(campaign_id=campaign_id, state="failed")
raise
except Exception as e:
logger.error(f"Error processing batch for campaign {campaign_id}: {e}")
# Publish batch failed event
publisher = await get_campaign_event_publisher()
await publisher.publish_batch_failed(
campaign_id=campaign_id,
error=str(e),
processed_count=0,
)
# Update campaign state to failed
await db_client.update_campaign(campaign_id=campaign_id, state="failed")
raise