mirror of
https://github.com/dograh-hq/dograh.git
synced 2026-06-22 08:38:13 +02:00
7d053320df
* fix: disable duplicate trigger nodes in workflow builder AddNodePanel: disable trigger buttons and show tooltip when a trigger already exists on the canvas, using bySpecName to identify trigger- category specs from the live node list. useWorkflowState: preflight in saveWorkflow rejects saves with multiple trigger nodes via a sonner toast before the network request is made. text_chat_session_service: include the original exception message in TextChatSessionExecutionError so the HTTP 500 detail surfaces the root cause without DB inspection. Closes #378 * style: format test_text_chat_session_service.py with ruff * chore: retrigger CI checks * fix(workflow): enforce node instance constraints --------- Co-authored-by: Abhishek Kumar <abhishek@a6k.me>
84 lines
2.6 KiB
Python
84 lines
2.6 KiB
Python
from types import SimpleNamespace
|
|
from unittest.mock import patch
|
|
|
|
from fastapi import FastAPI
|
|
from fastapi.testclient import TestClient
|
|
|
|
from api.routes.workflow import router
|
|
from api.services.auth.depends import get_user
|
|
|
|
|
|
def _make_test_app() -> FastAPI:
|
|
app = FastAPI()
|
|
app.include_router(router)
|
|
app.dependency_overrides[get_user] = lambda: SimpleNamespace(
|
|
id=1,
|
|
provider_id="provider-1",
|
|
selected_organization_id=11,
|
|
)
|
|
return app
|
|
|
|
|
|
def test_create_workflow_rejects_invalid_trigger_path_before_db_write():
|
|
app = _make_test_app()
|
|
client = TestClient(app)
|
|
|
|
with patch("api.routes.workflow.db_client") as mock_db:
|
|
response = client.post(
|
|
"/workflow/create/definition",
|
|
json={
|
|
"name": "Support Agent",
|
|
"workflow_definition": {
|
|
"nodes": [
|
|
{
|
|
"id": "trigger-1",
|
|
"type": "trigger",
|
|
"data": {"trigger_path": "support/west"},
|
|
}
|
|
],
|
|
"edges": [],
|
|
},
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 422
|
|
detail = response.json()["detail"]
|
|
assert detail["is_valid"] is False
|
|
assert detail["errors"][0]["field"] == "data.trigger_path"
|
|
assert "single URL path segment" in detail["errors"][0]["message"]
|
|
assert mock_db.mock_calls == []
|
|
|
|
|
|
def test_create_workflow_rejects_duplicate_api_triggers_before_db_write():
|
|
app = _make_test_app()
|
|
client = TestClient(app)
|
|
|
|
with patch("api.routes.workflow.db_client") as mock_db:
|
|
response = client.post(
|
|
"/workflow/create/definition",
|
|
json={
|
|
"name": "Support Agent",
|
|
"workflow_definition": {
|
|
"nodes": [
|
|
{
|
|
"id": "trigger-1",
|
|
"type": "trigger",
|
|
"data": {"trigger_path": "support_west"},
|
|
},
|
|
{
|
|
"id": "trigger-2",
|
|
"type": "trigger",
|
|
"data": {"trigger_path": "support_east"},
|
|
},
|
|
],
|
|
"edges": [],
|
|
},
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 422
|
|
detail = response.json()["detail"]
|
|
assert detail["is_valid"] is False
|
|
assert detail["errors"][0]["kind"] == "workflow"
|
|
assert "at most one API Trigger" in detail["errors"][0]["message"]
|
|
assert mock_db.mock_calls == []
|