mirror of
https://github.com/dograh-hq/dograh.git
synced 2026-06-28 08:49:42 +02:00
3309face2c
* fix: reject misrouted smallwebrtc runs on the telephony websocket A smallwebrtc (browser/WebRTC) workflow run is established through the WebRTC signaling endpoint, not the PSTN telephony websocket. When such a run reached _handle_telephony_websocket it read no "provider" from initial_context and closed with an opaque "Provider type not found". Detect smallwebrtc runs and close with a clear reason pointing to the signaling endpoint, without setting the run to running or invoking a telephony provider. Also store the provider on smallwebrtc runs at creation so they are self-describing, and make the generic no-provider close reason include the run id and mode. Closes #433 * fix: merge workflow run initial context defaults --------- Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Abhishek Kumar <abhishek@a6k.me>
257 lines
8.3 KiB
Python
257 lines
8.3 KiB
Python
from types import SimpleNamespace
|
|
from unittest.mock import ANY, AsyncMock, Mock, patch
|
|
|
|
import pytest
|
|
from fastapi import FastAPI
|
|
from fastapi.testclient import TestClient
|
|
|
|
from api.enums import WorkflowRunMode, WorkflowRunState
|
|
from api.routes.telephony import _handle_telephony_websocket, router
|
|
from api.services.auth.depends import get_user
|
|
|
|
|
|
def _make_test_app() -> FastAPI:
|
|
app = FastAPI()
|
|
app.include_router(router)
|
|
app.dependency_overrides[get_user] = lambda: SimpleNamespace(
|
|
id=7,
|
|
selected_organization_id=11,
|
|
)
|
|
return app
|
|
|
|
|
|
def _workflow(*, workflow_id: int = 33, user_id: int = 99):
|
|
return SimpleNamespace(
|
|
id=workflow_id,
|
|
user_id=user_id,
|
|
organization_id=11,
|
|
template_context_variables={"template_key": "template-value"},
|
|
)
|
|
|
|
|
|
def _provider():
|
|
return SimpleNamespace(
|
|
PROVIDER_NAME="twilio",
|
|
WEBHOOK_ENDPOINT="twilio/voice",
|
|
validate_config=Mock(return_value=True),
|
|
initiate_call=AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
caller_number="+15550001111",
|
|
provider_metadata={"call_id": "call-123"},
|
|
)
|
|
),
|
|
)
|
|
|
|
|
|
def test_initiate_call_executes_as_workflow_owner_for_shared_org_workflow():
|
|
app = _make_test_app()
|
|
client = TestClient(app)
|
|
|
|
workflow = _workflow()
|
|
provider = _provider()
|
|
quota_mock = AsyncMock(
|
|
return_value=SimpleNamespace(has_quota=True, error_message="")
|
|
)
|
|
|
|
with (
|
|
patch("api.routes.telephony.db_client") as mock_db,
|
|
patch(
|
|
"api.routes.telephony.authorize_workflow_run_start",
|
|
new=quota_mock,
|
|
),
|
|
patch(
|
|
"api.routes.telephony.get_default_telephony_provider",
|
|
new=AsyncMock(return_value=provider),
|
|
),
|
|
patch(
|
|
"api.routes.telephony.get_backend_endpoints",
|
|
new=AsyncMock(return_value=("https://api.example.com", "wss://ignored")),
|
|
),
|
|
):
|
|
mock_db.get_user_configurations = AsyncMock(
|
|
return_value=SimpleNamespace(test_phone_number=None)
|
|
)
|
|
mock_db.get_default_telephony_configuration = AsyncMock(
|
|
return_value=SimpleNamespace(id=55)
|
|
)
|
|
mock_db.get_workflow = AsyncMock(return_value=workflow)
|
|
mock_db.create_workflow_run = AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
id=501,
|
|
name="WR-TEL-OUT-00000001",
|
|
initial_context={"template_key": "template-value"},
|
|
)
|
|
)
|
|
mock_db.update_workflow_run = AsyncMock()
|
|
|
|
response = client.post(
|
|
"/telephony/initiate-call",
|
|
json={"workflow_id": workflow.id, "phone_number": "+15551234567"},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
quota_mock.assert_awaited_once_with(
|
|
workflow_id=workflow.id,
|
|
workflow_run_id=501,
|
|
actor_user=ANY,
|
|
)
|
|
mock_db.get_workflow.assert_awaited_once_with(workflow.id, organization_id=11)
|
|
|
|
create_call = mock_db.create_workflow_run.await_args
|
|
create_args = create_call.args
|
|
create_kwargs = create_call.kwargs
|
|
assert create_args[1] == workflow.id
|
|
assert create_kwargs["user_id"] == workflow.user_id
|
|
assert create_kwargs["organization_id"] == workflow.organization_id
|
|
assert create_kwargs["initial_context"]["template_key"] == "template-value"
|
|
|
|
initiate_kwargs = provider.initiate_call.await_args.kwargs
|
|
assert initiate_kwargs["workflow_id"] == workflow.id
|
|
assert initiate_kwargs["user_id"] == workflow.user_id
|
|
assert "user_id=99" in initiate_kwargs["webhook_url"]
|
|
mock_db.get_user_configurations.assert_not_called()
|
|
|
|
|
|
def test_initiate_call_uses_organization_preference_phone_number():
|
|
app = _make_test_app()
|
|
client = TestClient(app)
|
|
|
|
workflow = _workflow()
|
|
provider = _provider()
|
|
quota_mock = AsyncMock(
|
|
return_value=SimpleNamespace(has_quota=True, error_message="")
|
|
)
|
|
|
|
with (
|
|
patch("api.routes.telephony.db_client") as mock_db,
|
|
patch(
|
|
"api.routes.telephony.authorize_workflow_run_start",
|
|
new=quota_mock,
|
|
),
|
|
patch(
|
|
"api.routes.telephony.get_default_telephony_provider",
|
|
new=AsyncMock(return_value=provider),
|
|
),
|
|
patch(
|
|
"api.routes.telephony.get_backend_endpoints",
|
|
new=AsyncMock(return_value=("https://api.example.com", "wss://ignored")),
|
|
),
|
|
):
|
|
mock_db.get_user_configurations = AsyncMock(
|
|
return_value=SimpleNamespace(test_phone_number="+15550000000")
|
|
)
|
|
mock_db.get_configuration = Mock(
|
|
return_value=SimpleNamespace(value={"test_phone_number": "+15557654321"})
|
|
)
|
|
mock_db.get_default_telephony_configuration = AsyncMock(
|
|
return_value=SimpleNamespace(id=55)
|
|
)
|
|
mock_db.get_workflow = AsyncMock(return_value=workflow)
|
|
mock_db.create_workflow_run = AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
id=501,
|
|
name="WR-TEL-OUT-00000001",
|
|
initial_context={},
|
|
)
|
|
)
|
|
mock_db.update_workflow_run = AsyncMock()
|
|
|
|
response = client.post(
|
|
"/telephony/initiate-call",
|
|
json={"workflow_id": workflow.id},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert provider.initiate_call.await_args.kwargs["to_number"] == "+15557654321"
|
|
mock_db.get_user_configurations.assert_not_called()
|
|
|
|
|
|
def test_initiate_call_rejects_existing_run_for_different_workflow():
|
|
app = _make_test_app()
|
|
client = TestClient(app)
|
|
|
|
workflow = _workflow()
|
|
provider = _provider()
|
|
quota_mock = AsyncMock(
|
|
return_value=SimpleNamespace(has_quota=True, error_message="")
|
|
)
|
|
|
|
with (
|
|
patch("api.routes.telephony.db_client") as mock_db,
|
|
patch(
|
|
"api.routes.telephony.authorize_workflow_run_start",
|
|
new=quota_mock,
|
|
),
|
|
patch(
|
|
"api.routes.telephony.get_default_telephony_provider",
|
|
new=AsyncMock(return_value=provider),
|
|
),
|
|
):
|
|
mock_db.get_user_configurations = AsyncMock(
|
|
return_value=SimpleNamespace(test_phone_number=None)
|
|
)
|
|
mock_db.get_default_telephony_configuration = AsyncMock(
|
|
return_value=SimpleNamespace(id=55)
|
|
)
|
|
mock_db.get_workflow = AsyncMock(return_value=workflow)
|
|
mock_db.get_workflow_run = AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
id=501,
|
|
workflow_id=44,
|
|
name="WR-TEL-OUT-00000044",
|
|
initial_context={},
|
|
)
|
|
)
|
|
|
|
response = client.post(
|
|
"/telephony/initiate-call",
|
|
json={
|
|
"workflow_id": workflow.id,
|
|
"workflow_run_id": 501,
|
|
"phone_number": "+15551234567",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 400
|
|
assert response.json()["detail"] == "workflow_run_workflow_mismatch"
|
|
mock_db.get_workflow_run.assert_awaited_once_with(501, organization_id=11)
|
|
assert not mock_db.create_workflow_run.called
|
|
assert provider.initiate_call.await_count == 0
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_smallwebrtc_run_reaching_telephony_websocket_closes_without_running():
|
|
websocket = AsyncMock()
|
|
workflow_run = SimpleNamespace(
|
|
id=501,
|
|
workflow_id=33,
|
|
mode=WorkflowRunMode.SMALLWEBRTC.value,
|
|
state=WorkflowRunState.INITIALIZED.value,
|
|
initial_context={},
|
|
gathered_context={},
|
|
)
|
|
workflow = SimpleNamespace(id=33, organization_id=11)
|
|
provider_lookup = AsyncMock()
|
|
|
|
with (
|
|
patch("api.routes.telephony.db_client") as mock_db,
|
|
patch(
|
|
"api.routes.telephony.get_telephony_provider_for_run",
|
|
new=provider_lookup,
|
|
),
|
|
):
|
|
mock_db.get_workflow_run = AsyncMock(return_value=workflow_run)
|
|
mock_db.get_workflow_by_id = AsyncMock(return_value=workflow)
|
|
mock_db.update_workflow_run = AsyncMock()
|
|
|
|
await _handle_telephony_websocket(websocket, 33, 99, 501)
|
|
|
|
websocket.close.assert_awaited_once_with(
|
|
code=4400,
|
|
reason=(
|
|
"smallwebrtc runs connect through the WebRTC signaling endpoint, "
|
|
"not the telephony websocket"
|
|
),
|
|
)
|
|
assert mock_db.update_workflow_run.await_count == 0
|
|
assert provider_lookup.await_count == 0
|