feat: campaign create error on missing template variables

api/services/campaign/source_sync.py

@@ -1,6 +1,6 @@
 from abc import ABC, abstractmethod
-from dataclasses import dataclass
-from typing import Any, Dict, List, Optional
+from dataclasses import dataclass, field
+from typing import Any, Dict, List, Optional, Set
 
 from loguru import logger
 
@@ -19,6 +19,8 @@ class ValidationResult:
 
     is_valid: bool
     error: Optional[ValidationError] = None
+    headers: Optional[List[str]] = field(default=None, repr=False)
+    rows: Optional[List[List[str]]] = field(default=None, repr=False)
 
 
 class CampaignSourceSyncService(ABC):
@@ -113,6 +115,53 @@ class CampaignSourceSyncService(ABC):
                 ),
             )
 
+        return ValidationResult(is_valid=True, headers=normalized_headers, rows=rows)
+
+    @staticmethod
+    def validate_template_columns(
+        headers: List[str],
+        rows: List[List[str]],
+        required_columns: Set[str],
+    ) -> ValidationResult:
+        """Validate that template variable columns exist and are non-empty in all rows."""
+        normalized_headers = CampaignSourceSyncService.normalize_headers(headers)
+
+        # Check for missing columns
+        missing = required_columns - set(normalized_headers)
+        if missing:
+            missing_str = ", ".join(f"'{c}'" for c in sorted(missing))
+            return ValidationResult(
+                is_valid=False,
+                error=ValidationError(
+                    message=f"Workflow uses template variables that are missing from the source data: {missing_str}. "
+                    "Add the missing columns or remove them from the workflow."
+                ),
+            )
+
+        # Check for empty values in required columns
+        col_indices = {col: normalized_headers.index(col) for col in required_columns}
+
+        for col, idx in col_indices.items():
+            empty_rows = []
+            for row_idx, row in enumerate(rows, start=2):
+                if len(row) <= idx or not row[idx].strip():
+                    empty_rows.append(row_idx)
+
+            if empty_rows:
+                if len(empty_rows) > 5:
+                    rows_str = f"{', '.join(map(str, empty_rows[:5]))} and {len(empty_rows) - 5} more"
+                else:
+                    rows_str = ", ".join(map(str, empty_rows))
+
+                return ValidationResult(
+                    is_valid=False,
+                    error=ValidationError(
+                        message=f"Template variable '{col}' is empty in rows: {rows_str}. "
+                        "All template variables used in the workflow must have values in every row.",
+                        invalid_rows=empty_rows,
+                    ),
+                )
+
         return ValidationResult(is_valid=True)
 
     @abstractmethod

api/services/workflow/workflow.py

@@ -1,10 +1,40 @@
 import re
 from collections import Counter
-from typing import Dict, List
+from typing import Dict, List, Set
 
 from api.services.workflow.dto import EdgeDataDTO, NodeDataDTO, NodeType, ReactFlowDTO
 from api.services.workflow.errors import ItemKind, WorkflowError
 
+# Regex for matching {{ variable }} template placeholders.
+# Captures: group(1) = variable path, group(2) = filter name, group(3) = filter value.
+# Shared with api.utils.template_renderer via import.
+TEMPLATE_VAR_PATTERN = r"\{\{\s*([^|\s}]+)(?:\s*\|\s*([^:}]+)(?::([^}]+))?)?\s*\}\}"
+
+# Variables injected by the system at runtime, not from source data.
+_SYSTEM_VARIABLES = {"campaign_id", "provider", "source_uuid"}
+
+
+def extract_template_variables(text: str) -> Set[str]:
+    """Extract template variable names from a string, excluding nested paths,
+    variables with a fallback filter, and system-injected variables."""
+    variables: Set[str] = set()
+    for match in re.finditer(TEMPLATE_VAR_PATTERN, text):
+        var_name = match.group(1).strip()
+        filter_name = match.group(2).strip() if match.group(2) else None
+
+        # Skip nested paths (runtime-resolved, e.g. gathered_context.city)
+        if "." in var_name:
+            continue
+        # Skip variables with a fallback (they have a default value)
+        if filter_name == "fallback":
+            continue
+        # Skip system-injected variables
+        if var_name in _SYSTEM_VARIABLES:
+            continue
+
+        variables.add(var_name)
+    return variables
+
 
 class Edge:
     def __init__(self, source: str, target: str, data: EdgeDataDTO):
@@ -99,6 +129,44 @@ class WorkflowGraph:
         except IndexError:
             self.global_node_id = None
 
+    # -----------------------------------------------------------
+    # template variable extraction
+    # -----------------------------------------------------------
+    def get_required_template_variables(self) -> Set[str]:
+        """Extract all template variables referenced in node prompts/greetings
+        and edge transition speeches.
+
+        Scans:
+          - Start node: prompt, greeting
+          - Agent / End / Global nodes: prompt
+          - All edges: transition_speech
+
+        Returns a set of top-level variable names that the workflow expects
+        from the source data (excluding nested paths, fallback vars, and
+        system-injected vars).
+        """
+        variables: Set[str] = set()
+
+        for node in self.nodes.values():
+            if node.node_type in (
+                NodeType.startNode,
+                NodeType.agentNode,
+                NodeType.endNode,
+                NodeType.globalNode,
+            ):
+                if node.prompt:
+                    variables |= extract_template_variables(node.prompt)
+
+            # greeting is only relevant on the start node
+            if node.node_type == NodeType.startNode and node.greeting:
+                variables |= extract_template_variables(node.greeting)
+
+        for edge in self.edges:
+            if edge.transition_speech:
+                variables |= extract_template_variables(edge.transition_speech)
+
+        return variables
+
     # -----------------------------------------------------------
     # validators
     # -----------------------------------------------------------