apunkt/dograh
1
0
Fork 0
mirror of https://github.com/dograh-hq/dograh.git synced 2026-06-25 08:48:13 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(telephony): resolve transfer context via call-sid index instead of KEYS scan (#387)

Browse source 
Transfer-context lookup by original_call_sid ran
`redis.keys("transfer:context:*")` and iterated every match — an O(N)
blocking scan on call-control hot paths, duplicated across the ARI
manager and the Twilio/Telnyx conference strategies.

Maintain a `transfer:by_call_sid:{original_call_sid}` -> transfer_id
secondary index, written and cleared alongside the context in
store/remove, and resolve lookups with a direct GET. Route the
Twilio/Telnyx strategies through the manager so the lookup lives in one
place (also dropping per-call ad-hoc Redis connections).

Closes #328

Co-authored-by: shiminshen <16914659+shiminshen@users.noreply.github.com>
This commit is contained in:
shiminshen 2026-06-02 15:26:05 +08:00 • committed by GitHub
parent 7ba95c0fbe
commit 37e7f4d2e6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 160 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

44
api/services/telephony/call_transfer_manager.py
View file

@ -47,6 +47,11 @@ class CallTransferManager:
redis = await self._get_redis()
key = TransferRedisChannels.transfer_context_key(context.transfer_id)
await redis.setex(key, ttl, context.to_json())
if context.original_call_sid:
index_key = TransferRedisChannels.transfer_context_by_call_sid_key(
context.original_call_sid
)
await redis.setex(index_key, ttl, context.transfer_id)
logger.debug(f"Stored transfer context for {context.transfer_id}")
except Exception as e:
logger.error(f"Failed to store transfer context: {e}")
@ -79,8 +84,15 @@ class CallTransferManager:
"""
try:
redis = await self._get_redis()
context = await self.get_transfer_context(transfer_id)
key = TransferRedisChannels.transfer_context_key(transfer_id)
await redis.delete(key)
if context and context.original_call_sid:
index_key = TransferRedisChannels.transfer_context_by_call_sid_key(
context.original_call_sid
)
await redis.delete(key, index_key)
else:
await redis.delete(key)
logger.debug(f"Removed transfer context for {transfer_id}")
except Exception as e:
logger.error(f"Failed to remove transfer context: {e}")
@ -186,24 +198,24 @@ class CallTransferManager:
logger.error(f"Error closing pubsub connection: {e}")
async def find_transfer_context_for_call(self, caller_channel_id: str):
"""Find the active transfer context for this caller channel."""
redis = await self._get_redis()
"""Find the active transfer context for this caller channel.
Resolves via the original_call_sid -> transfer_id secondary index
(see store_transfer_context) instead of scanning the keyspace with
``KEYS transfer:context:*``.
"""
try:
# Search Redis for transfer contexts where original_call_sid matches this caller
transfer_keys = await redis.keys("transfer:context:*")
for key in transfer_keys:
try:
context_data = await redis.get(key)
if context_data:
context = TransferContext.from_json(context_data)
if context.original_call_sid == caller_channel_id:
return context
except Exception:
continue
redis = await self._get_redis()
index_key = TransferRedisChannels.transfer_context_by_call_sid_key(
caller_channel_id
)
transfer_id = await redis.get(index_key)
if not transfer_id:
return None
context = await self.get_transfer_context(transfer_id)
if context and context.original_call_sid == caller_channel_id:
return context
return None
except Exception as e: