From 88d5c375edec89a3eba9b960b40f4187468d9cf5 Mon Sep 17 00:00:00 2001
From: 51616 <rujikorn.ch@gmail.com>
Date: Mon, 23 Jun 2025 13:31:38 +0900
Subject: [PATCH] fix metric_for_best_model default

---
 src/ctx_to_lora/configs.py | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/ctx_to_lora/configs.py b/src/ctx_to_lora/configs.py
index 502e1e0..5fb8ca0 100644
--- a/src/ctx_to_lora/configs.py
+++ b/src/ctx_to_lora/configs.py
@@ -201,18 +201,18 @@ class TrainingArguments(TrainingArguments):
         default=10_000,
         metadata={"help": "Evaluation steps."},
     )
-    # metric_for_best_model: str = field(
-    #     default="val_loss",
-    #     metadata={"help": "Metric for best model."},
-    # )
+    metric_for_best_model: str = field(
+        default=None,
+        metadata={"help": "Metric for best model."},
+    )
     # greater_is_better: bool = field(
     #     default=False,
     #     metadata={"help": "Whether the metric is better when it is greater."},
     # )
-    # load_best_model_at_end: bool = field(
-    #     default=False,
-    #     metadata={"help": "Whether to load the best model at the end of training."},
-    # )
+    load_best_model_at_end: bool = field(
+        default=False,
+        metadata={"help": "Whether to load the best model at the end of training."},
+    )
     save_total_limit: int = field(
         default=2,
         metadata={"help": "Total number of checkpoints to save."},