mirror of
https://github.com/MODSetter/SurfSense.git
synced 2026-05-29 19:35:20 +02:00
c0232fdcfe
Manual-as-a-standalone-trigger conflates "user clicks Run now" with the
trigger model and forces ad-hoc input plumbing on the caller. Remove the
unreachable surface so the tree reflects reality (schedule is the only
v1 trigger).
- Unregister `manual`: drop import from triggers/__init__.py
- Delete `app/automations/triggers/manual/`
- Drop `RunService.dispatch_manual` (RunService is now read-only)
- Drop `POST /automations/{id}/run` and `RunDispatched` schema
- Keep `TriggerType.MANUAL` Python + PG enum value (reserved, documented)
to avoid an Alembic round-trip when Run-now is redesigned
72 lines
2.6 KiB
Python
72 lines
2.6 KiB
Python
"""``RunService`` — read-only access to automation run history."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from fastapi import Depends, HTTPException
|
|
from sqlalchemy import func, select
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from app.automations.persistence.models.automation import Automation
|
|
from app.automations.persistence.models.run import AutomationRun
|
|
from app.db import Permission, User, get_async_session
|
|
from app.users import current_active_user
|
|
from app.utils.rbac import check_permission
|
|
|
|
|
|
class RunService:
|
|
"""Read-only access to ``AutomationRun`` history."""
|
|
|
|
def __init__(self, *, session: AsyncSession, user: User) -> None:
|
|
self.session = session
|
|
self.user = user
|
|
|
|
async def list(
|
|
self,
|
|
*,
|
|
automation_id: int,
|
|
limit: int,
|
|
offset: int,
|
|
) -> tuple[list[AutomationRun], int]:
|
|
"""Return a page of runs for an automation, newest first."""
|
|
await self._authorize(automation_id, Permission.AUTOMATIONS_READ.value)
|
|
|
|
base = select(AutomationRun).where(AutomationRun.automation_id == automation_id)
|
|
total = await self.session.scalar(
|
|
select(func.count()).select_from(base.subquery())
|
|
)
|
|
|
|
rows = (
|
|
await self.session.execute(
|
|
base.order_by(AutomationRun.created_at.desc()).limit(limit).offset(offset)
|
|
)
|
|
).scalars().all()
|
|
return list(rows), int(total or 0)
|
|
|
|
async def get(self, *, automation_id: int, run_id: int) -> AutomationRun:
|
|
await self._authorize(automation_id, Permission.AUTOMATIONS_READ.value)
|
|
run = await self.session.get(AutomationRun, run_id)
|
|
if run is None or run.automation_id != automation_id:
|
|
raise HTTPException(status_code=404, detail=f"run {run_id} not found")
|
|
return run
|
|
|
|
async def _authorize(self, automation_id: int, permission: str) -> Automation:
|
|
automation = await self.session.get(Automation, automation_id)
|
|
if automation is None:
|
|
raise HTTPException(
|
|
status_code=404, detail=f"automation {automation_id} not found"
|
|
)
|
|
await check_permission(
|
|
self.session,
|
|
self.user,
|
|
automation.search_space_id,
|
|
permission,
|
|
f"You don't have permission to {permission.split(':')[1]} automations in this search space",
|
|
)
|
|
return automation
|
|
|
|
|
|
def get_run_service(
|
|
session: AsyncSession = Depends(get_async_session),
|
|
user: User = Depends(current_active_user),
|
|
) -> RunService:
|
|
return RunService(session=session, user=user)
|