mirror of
https://github.com/MODSetter/SurfSense.git
synced 2026-05-17 18:35:19 +02:00
bf2b4ebeb0
Closes #1371. Retarget of #1385 onto dev per maintainer request. surfsense_web/lib/query-client/client.ts configures a global MutationCache.onError that shows an error toast for every failed mutation unless meta.suppressGlobalErrorToast is set. The opt-out hook existed in the consumer but had zero producers — every mutation atom that already had its own onError: toast.error(...) was double-toasting on failure. Add meta: { suppressGlobalErrorToast: true } to the 30 mutations across 9 atom files that own their own error toast: - atoms/prompts/prompts-mutation.atoms.ts (4) - atoms/invites/invites-mutation.atoms.ts (4) - atoms/chat-comments/comments-mutation.atoms.ts (4) - atoms/new-llm-config/new-llm-config-mutation.atoms.ts (4) - atoms/members/members-mutation.atoms.ts (3) - atoms/roles/roles-mutation.atoms.ts (3) - atoms/image-gen-config/image-gen-config-mutation.atoms.ts (3) - atoms/vision-llm-config/vision-llm-config-mutation.atoms.ts (3) - atoms/public-chat-snapshots/public-chat-snapshots-mutation.atoms.ts (2) Atoms intentionally left alone (no local onError, rely on global): auth, user, search-spaces, logs, documents, connectors. Local validation (against dev): pnpm biome check on the 9 touched files is clean; tsc --noEmit shows no new errors in the touched files (pre-existing errors elsewhere unrelated). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
76 lines
2.5 KiB
TypeScript
76 lines
2.5 KiB
TypeScript
import { atomWithMutation } from "jotai-tanstack-query";
|
|
import { toast } from "sonner";
|
|
import type {
|
|
CreateCommentRequest,
|
|
CreateReplyRequest,
|
|
DeleteCommentRequest,
|
|
UpdateCommentRequest,
|
|
} from "@/contracts/types/chat-comments.types";
|
|
import { chatCommentsApiService } from "@/lib/apis/chat-comments-api.service";
|
|
import { cacheKeys } from "@/lib/query-client/cache-keys";
|
|
import { queryClient } from "@/lib/query-client/client";
|
|
|
|
export const createCommentMutationAtom = atomWithMutation(() => ({
|
|
meta: { suppressGlobalErrorToast: true },
|
|
mutationFn: async (request: CreateCommentRequest) => {
|
|
return chatCommentsApiService.createComment(request);
|
|
},
|
|
onSuccess: (_, variables) => {
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.comments.byMessage(variables.message_id),
|
|
});
|
|
},
|
|
onError: (error: Error) => {
|
|
console.error("Error creating comment:", error);
|
|
toast.error("Failed to create comment");
|
|
},
|
|
}));
|
|
|
|
export const createReplyMutationAtom = atomWithMutation(() => ({
|
|
meta: { suppressGlobalErrorToast: true },
|
|
mutationFn: async (request: CreateReplyRequest & { message_id: number }) => {
|
|
return chatCommentsApiService.createReply(request);
|
|
},
|
|
onSuccess: (_, variables) => {
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.comments.byMessage(variables.message_id),
|
|
});
|
|
},
|
|
onError: (error: Error) => {
|
|
console.error("Error creating reply:", error);
|
|
toast.error("Failed to create reply");
|
|
},
|
|
}));
|
|
|
|
export const updateCommentMutationAtom = atomWithMutation(() => ({
|
|
meta: { suppressGlobalErrorToast: true },
|
|
mutationFn: async (request: UpdateCommentRequest & { message_id: number }) => {
|
|
return chatCommentsApiService.updateComment(request);
|
|
},
|
|
onSuccess: (_, variables) => {
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.comments.byMessage(variables.message_id),
|
|
});
|
|
},
|
|
onError: (error: Error) => {
|
|
console.error("Error updating comment:", error);
|
|
toast.error("Failed to update comment");
|
|
},
|
|
}));
|
|
|
|
export const deleteCommentMutationAtom = atomWithMutation(() => ({
|
|
meta: { suppressGlobalErrorToast: true },
|
|
mutationFn: async (request: DeleteCommentRequest & { message_id: number }) => {
|
|
return chatCommentsApiService.deleteComment(request);
|
|
},
|
|
onSuccess: (_, variables) => {
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.comments.byMessage(variables.message_id),
|
|
});
|
|
toast.success("Comment deleted");
|
|
},
|
|
onError: (error: Error) => {
|
|
console.error("Error deleting comment:", error);
|
|
toast.error("Failed to delete comment");
|
|
},
|
|
}));
|