mirror of
https://github.com/MODSetter/SurfSense.git
synced 2026-05-19 18:45:15 +02:00
bf2b4ebeb0
Closes #1371. Retarget of #1385 onto dev per maintainer request. surfsense_web/lib/query-client/client.ts configures a global MutationCache.onError that shows an error toast for every failed mutation unless meta.suppressGlobalErrorToast is set. The opt-out hook existed in the consumer but had zero producers — every mutation atom that already had its own onError: toast.error(...) was double-toasting on failure. Add meta: { suppressGlobalErrorToast: true } to the 30 mutations across 9 atom files that own their own error toast: - atoms/prompts/prompts-mutation.atoms.ts (4) - atoms/invites/invites-mutation.atoms.ts (4) - atoms/chat-comments/comments-mutation.atoms.ts (4) - atoms/new-llm-config/new-llm-config-mutation.atoms.ts (4) - atoms/members/members-mutation.atoms.ts (3) - atoms/roles/roles-mutation.atoms.ts (3) - atoms/image-gen-config/image-gen-config-mutation.atoms.ts (3) - atoms/vision-llm-config/vision-llm-config-mutation.atoms.ts (3) - atoms/public-chat-snapshots/public-chat-snapshots-mutation.atoms.ts (2) Atoms intentionally left alone (no local onError, rely on global): auth, user, search-spaces, logs, documents, connectors. Local validation (against dev): pnpm biome check on the 9 touched files is clean; tsc --noEmit shows no new errors in the touched files (pre-existing errors elsewhere unrelated). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
73 lines
2.1 KiB
TypeScript
73 lines
2.1 KiB
TypeScript
import { atomWithMutation } from "jotai-tanstack-query";
|
|
import { toast } from "sonner";
|
|
import type {
|
|
CreateRoleRequest,
|
|
CreateRoleResponse,
|
|
DeleteRoleRequest,
|
|
DeleteRoleResponse,
|
|
UpdateRoleRequest,
|
|
UpdateRoleResponse,
|
|
} from "@/contracts/types/roles.types";
|
|
import { rolesApiService } from "@/lib/apis/roles-api.service";
|
|
import { cacheKeys } from "@/lib/query-client/cache-keys";
|
|
import { queryClient } from "@/lib/query-client/client";
|
|
|
|
export const createRoleMutationAtom = atomWithMutation(() => {
|
|
return {
|
|
meta: { suppressGlobalErrorToast: true },
|
|
mutationFn: async (request: CreateRoleRequest) => {
|
|
return rolesApiService.createRole(request);
|
|
},
|
|
onSuccess: (_: CreateRoleResponse, request: CreateRoleRequest) => {
|
|
toast.success("Role created successfully");
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.roles.all(request.search_space_id.toString()),
|
|
});
|
|
},
|
|
onError: () => {
|
|
toast.error("Failed to create role");
|
|
},
|
|
};
|
|
});
|
|
|
|
export const updateRoleMutationAtom = atomWithMutation(() => {
|
|
return {
|
|
meta: { suppressGlobalErrorToast: true },
|
|
mutationFn: async (request: UpdateRoleRequest) => {
|
|
return rolesApiService.updateRole(request);
|
|
},
|
|
onSuccess: (_: UpdateRoleResponse, request: UpdateRoleRequest) => {
|
|
toast.success("Role updated successfully");
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.roles.all(request.search_space_id.toString()),
|
|
});
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.roles.byId(
|
|
request.search_space_id.toString(),
|
|
request.role_id.toString()
|
|
),
|
|
});
|
|
},
|
|
onError: () => {
|
|
toast.error("Failed to update role");
|
|
},
|
|
};
|
|
});
|
|
|
|
export const deleteRoleMutationAtom = atomWithMutation(() => {
|
|
return {
|
|
meta: { suppressGlobalErrorToast: true },
|
|
mutationFn: async (request: DeleteRoleRequest) => {
|
|
return rolesApiService.deleteRole(request);
|
|
},
|
|
onSuccess: (_: DeleteRoleResponse, request: DeleteRoleRequest) => {
|
|
toast.success("Role deleted successfully");
|
|
queryClient.invalidateQueries({
|
|
queryKey: cacheKeys.roles.all(request.search_space_id.toString()),
|
|
});
|
|
},
|
|
onError: () => {
|
|
toast.error("Failed to delete role");
|
|
},
|
|
};
|
|
});
|