apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-07-14 22:52:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: memoize formatRelativeTime in thread list to prevent unnecessary re-renders

Browse source 
ThreadListItemComponent is wrapped in memo(), but formatRelativeTime(new
Date(thread.updatedAt)) was called inline during render, creating a new
Date on every parent re-render regardless of whether updatedAt changed.

Wrap the call in useMemo keyed on thread.updatedAt so the date formatting
only re-runs when the value actually changes.
This commit is contained in:
okxint 2026-06-15 23:24:12 +05:30
parent c1c4c534c0
commit f9b565fe86
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
surfsense_web/components/assistant-ui/thread-list.tsx
View file

@ -9,7 +9,7 @@ import {
TrashIcon,
} from "lucide-react";
import { useRouter } from "next/navigation";
import { memo, useCallback, useEffect, useState } from "react";
import { memo, useCallback, useEffect, useMemo, useState } from "react";
import { Button } from "@/components/ui/button";
import {
DropdownMenu,
@ -224,6 +224,11 @@ const ThreadListItemComponent = memo(function ThreadListItemComponent({
onUnarchive,
onDelete,
}: ThreadListItemComponentProps) {
const relativeTime = useMemo(
() => formatRelativeTime(new Date(thread.updatedAt)),
[thread.updatedAt]
);
return (
<button
type="button"
@ -237,7 +242,7 @@ const ThreadListItemComponent = memo(function ThreadListItemComponent({
<div className="flex-1 min-w-0">
<p className="truncate text-sm font-medium">{thread.title || "New Chat"}</p>
<p className="truncate text-xs text-muted-foreground">
{formatRelativeTime(new Date(thread.updatedAt))}
{relativeTime}
</p>
</div>
<DropdownMenu>