apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-05 13:52:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: refine indexing success case handling and notification messaging

Browse source 
- Enhanced the logic for determining success cases during indexing by distinguishing between duplicate warnings and empty results.
- Updated notification messages to provide clearer feedback for empty results, improving user understanding of indexing outcomes.
- Ensured that notifications reflect accurate statuses, maintaining consistency in user feedback during the indexing process.
This commit is contained in:
Anish Sarkar 2026-01-24 03:51:57 +05:30
parent 6d14b49d3f
commit f4b1192a06
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
surfsense_backend/app/routes/search_source_connectors_routes.py
View file

@ -1249,13 +1249,15 @@ async def _run_indexing_with_notifications(
else:
# No new documents processed - check if this is an error or just no changes
if error_or_warning:
# Check if this is a duplicate warning (success case) or an actual error
# Check if this is a duplicate warning or empty result (success cases) or an actual error
# Handle both normal and Composio calendar connectors
error_or_warning_lower = str(error_or_warning).lower() if error_or_warning else ""
is_duplicate_warning = "skipped (duplicate)" in error_or_warning_lower
# "No X found" messages are success cases - sync worked, just found nothing in date range
is_empty_result = ("no " in error_or_warning_lower and "found" in error_or_warning_lower)
if is_duplicate_warning:
# Duplicate warnings are success cases - sync worked, just found duplicates
if is_duplicate_warning or is_empty_result:
# These are success cases - sync worked, just found nothing new
logger.info(
f"Indexing completed successfully: {error_or_warning}"
)
@ -1266,11 +1268,13 @@ async def _run_indexing_with_notifications(
if notification:
# Refresh notification to ensure it's not stale after timestamp update commit
await session.refresh(notification)
# For empty results, use a cleaner message
notification_message = "No new items found in date range" if is_empty_result else error_or_warning
await NotificationService.connector_indexing.notify_indexing_completed(
session=session,
notification=notification,
indexed_count=0,
error_message=error_or_warning, # Pass as warning, not error
error_message=notification_message, # Pass as warning, not error
is_warning=True, # Flag to indicate this is a warning, not an error
)
await (