refactor: replace hardcoded embedding dimension with dynamic configuration

- Updated the embedding dimension in test configurations to use the value from the application config, enhancing maintainability and consistency across tests.
This commit is contained in:
Anish Sarkar 2026-02-27 00:17:39 +05:30
parent 223c2de0d2
commit f09b5b0ea4
2 changed files with 6 additions and 2 deletions

View file

@ -8,6 +8,7 @@ from sqlalchemy import text
from sqlalchemy.ext.asyncio import AsyncSession, create_async_engine
from sqlalchemy.pool import NullPool
from app.config import config as app_config
from app.db import (
Base,
DocumentType,
@ -18,7 +19,7 @@ from app.db import (
)
from app.indexing_pipeline.connector_document import ConnectorDocument
_EMBEDDING_DIM = 1024 # must match the Vector() dimension used in DB column creation
_EMBEDDING_DIM = app_config.embedding_model_instance.dimension
_DEFAULT_TEST_DB = (
"postgresql+asyncpg://postgres:postgres@localhost:5432/surfsense_test"

View file

@ -1,9 +1,12 @@
import pytest
from sqlalchemy import select
from app.config import config as app_config
from app.db import Chunk, Document, DocumentStatus
from app.indexing_pipeline.indexing_pipeline_service import IndexingPipelineService
_EMBEDDING_DIM = app_config.embedding_model_instance.dimension
pytestmark = pytest.mark.integration
@ -144,7 +147,7 @@ async def test_embedding_written_to_db(
reloaded = result.scalars().first()
assert reloaded.embedding is not None
assert len(reloaded.embedding) == 1024
assert len(reloaded.embedding) == _EMBEDDING_DIM
@pytest.mark.usefixtures(