From ef843fd82e6c7feef904f534774a21de50c6b27e Mon Sep 17 00:00:00 2001
From: Anish Sarkar <104695310+AnishSarkar22@users.noreply.github.com>
Date: Fri, 8 May 2026 01:16:55 +0530
Subject: [PATCH] refactor(tests): remove redundant visibility check for
 "Manage" button in connector journeys

---
 surfsense_web/tests/connectors/composio/calendar/journey.spec.ts | 1 -
 surfsense_web/tests/connectors/composio/drive/journey.spec.ts    | 1 -
 surfsense_web/tests/connectors/composio/gmail/journey.spec.ts    | 1 -
 surfsense_web/tests/connectors/google/calendar/journey.spec.ts   | 1 -
 surfsense_web/tests/connectors/google/drive/journey.spec.ts      | 1 -
 surfsense_web/tests/connectors/google/gmail/journey.spec.ts      | 1 -
 surfsense_web/tests/connectors/linear/journey.spec.ts            | 1 -
 surfsense_web/tests/connectors/notion/journey.spec.ts            | 1 -
 8 files changed, 8 deletions(-)

diff --git a/surfsense_web/tests/connectors/composio/calendar/journey.spec.ts b/surfsense_web/tests/connectors/composio/calendar/journey.spec.ts
index 700463fd2..66749349e 100644
--- a/surfsense_web/tests/connectors/composio/calendar/journey.spec.ts
+++ b/surfsense_web/tests/connectors/composio/calendar/journey.spec.ts
@@ -29,7 +29,6 @@ test.describe("Composio Calendar journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		const beforeChatDocs = await listDocuments(request, apiToken, searchSpace.id);
 		expect(beforeChatDocs).toHaveLength(0);
diff --git a/surfsense_web/tests/connectors/composio/drive/journey.spec.ts b/surfsense_web/tests/connectors/composio/drive/journey.spec.ts
index f3abde82c..62a074e4a 100644
--- a/surfsense_web/tests/connectors/composio/drive/journey.spec.ts
+++ b/surfsense_web/tests/connectors/composio/drive/journey.spec.ts
@@ -34,7 +34,6 @@ test.describe("Composio Drive journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		await updateConnectorConfig(request, apiToken, composioDriveConnector.id, {
 			...composioDriveConnector.config,
diff --git a/surfsense_web/tests/connectors/composio/gmail/journey.spec.ts b/surfsense_web/tests/connectors/composio/gmail/journey.spec.ts
index af0e9203f..fbca52e58 100644
--- a/surfsense_web/tests/connectors/composio/gmail/journey.spec.ts
+++ b/surfsense_web/tests/connectors/composio/gmail/journey.spec.ts
@@ -29,7 +29,6 @@ test.describe("Composio Gmail journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		const beforeChatDocs = await listDocuments(request, apiToken, searchSpace.id);
 		expect(beforeChatDocs).toHaveLength(0);
diff --git a/surfsense_web/tests/connectors/google/calendar/journey.spec.ts b/surfsense_web/tests/connectors/google/calendar/journey.spec.ts
index 6c076a89a..94cba0155 100644
--- a/surfsense_web/tests/connectors/google/calendar/journey.spec.ts
+++ b/surfsense_web/tests/connectors/google/calendar/journey.spec.ts
@@ -34,7 +34,6 @@ test.describe("Native Google Calendar journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		const beforeDocs = await listDocuments(request, apiToken, searchSpace.id);
 		expect(beforeDocs).toHaveLength(0);
diff --git a/surfsense_web/tests/connectors/google/drive/journey.spec.ts b/surfsense_web/tests/connectors/google/drive/journey.spec.ts
index 1a31bbd0b..8044fae58 100644
--- a/surfsense_web/tests/connectors/google/drive/journey.spec.ts
+++ b/surfsense_web/tests/connectors/google/drive/journey.spec.ts
@@ -39,7 +39,6 @@ test.describe("Native Google Drive journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		const selectedFiles = [
 			{
diff --git a/surfsense_web/tests/connectors/google/gmail/journey.spec.ts b/surfsense_web/tests/connectors/google/gmail/journey.spec.ts
index 4c3fd464d..6f61f6b82 100644
--- a/surfsense_web/tests/connectors/google/gmail/journey.spec.ts
+++ b/surfsense_web/tests/connectors/google/gmail/journey.spec.ts
@@ -34,7 +34,6 @@ test.describe("Native Google Gmail journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		const beforeDocs = await listDocuments(request, apiToken, searchSpace.id);
 		expect(beforeDocs).toHaveLength(0);
diff --git a/surfsense_web/tests/connectors/linear/journey.spec.ts b/surfsense_web/tests/connectors/linear/journey.spec.ts
index df55d7a38..a1ca7fbc8 100644
--- a/surfsense_web/tests/connectors/linear/journey.spec.ts
+++ b/surfsense_web/tests/connectors/linear/journey.spec.ts
@@ -44,7 +44,6 @@ test.describe("Linear connector journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		const beforeDocs = await listDocuments(request, apiToken, searchSpace.id);
 		expect(beforeDocs).toHaveLength(0);
diff --git a/surfsense_web/tests/connectors/notion/journey.spec.ts b/surfsense_web/tests/connectors/notion/journey.spec.ts
index 123adb98b..948353011 100644
--- a/surfsense_web/tests/connectors/notion/journey.spec.ts
+++ b/surfsense_web/tests/connectors/notion/journey.spec.ts
@@ -39,7 +39,6 @@ test.describe("Notion connector journey", () => {
 		await openConnectorPopup(page);
 		const connectorDialog = page.getByRole("dialog", { name: "Manage Connectors" });
 		await expect(connectorDialog).toBeVisible();
-		await expect(connectorDialog.getByRole("button", { name: "Manage" })).toBeVisible();
 
 		await triggerIndex(request, apiToken, notionConnector.id, searchSpace.id, {});