apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-08 15:22:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: clear stagger toast timers on unmount in AnnouncementToastProvider

Browse source 
Stagger setTimeout calls inside the for loop were never cleared on
component unmount, causing potential setState calls on unmounted
components when the user navigates away before all toasts fire.

Fixes #1094
This commit is contained in:
mac-agent 2026-04-04 07:02:51 -04:00
parent c2bd2bc935
commit e5a6feb6f6
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
surfsense_web/components/announcements/AnnouncementToastProvider.tsx
View file

@ -65,6 +65,8 @@ export function AnnouncementToastProvider() {
if (hasChecked.current) return;
hasChecked.current = true;
const staggerTimers: ReturnType<typeof setTimeout>[] = [];
const timer = setTimeout(() => {
const authed = isAuthenticated();
const active = getActiveAnnouncements(announcements, authed);
@ -74,11 +76,18 @@ export function AnnouncementToastProvider() {
for (let i = 0; i < importantUntoasted.length; i++) {
const announcement = importantUntoasted[i];
setTimeout(() => showAnnouncementToast(announcement), i * 800);
const staggerId = setTimeout(
() => showAnnouncementToast(announcement),
i * 800
);
staggerTimers.push(staggerId);
}
}, 1500);
return () => clearTimeout(timer);
return () => {
clearTimeout(timer);
staggerTimers.forEach((id) => clearTimeout(id));
};
}, []);
return null;