From e38e20b48407da9205ca7b7e26a62f8b8959b126 Mon Sep 17 00:00:00 2001
From: Anish Sarkar <104695310+AnishSarkar22@users.noreply.github.com>
Date: Mon, 4 May 2026 12:18:09 +0530
Subject: [PATCH] fix: handle empty response in forced rewrite function

- Updated the `_forced_rewrite` function to strip whitespace from the extracted text and added a warning log if the response is empty, preventing potential issues with empty rewrites.
---
 .../app/agents/new_chat/tools/update_memory.py             | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/surfsense_backend/app/agents/new_chat/tools/update_memory.py b/surfsense_backend/app/agents/new_chat/tools/update_memory.py
index 42148967c..062668aac 100644
--- a/surfsense_backend/app/agents/new_chat/tools/update_memory.py
+++ b/surfsense_backend/app/agents/new_chat/tools/update_memory.py
@@ -189,8 +189,11 @@ async def _forced_rewrite(content: str, llm: Any) -> str | None:
             [HumanMessage(content=prompt)],
             config={"tags": ["surfsense:internal"]},
         )
-        text = extract_text_content(response.content)
-        return text.strip()
+        text = extract_text_content(response.content).strip()
+        if not text:
+            logger.warning("Forced rewrite returned empty text; aborting rewrite")
+            return None
+        return text
     except Exception:
         logger.exception("Forced rewrite LLM call failed")
         return None