apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-10 00:02:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1073 from bluehyena/fix/issue-1046-immutable-sort

Browse source 
fix: avoid mutating shared arrays in changelog and comments sync issue 1046 immutable sort
This commit is contained in:
Rohan Verma 2026-04-01 13:02:30 -07:00 • committed by GitHub
commit e1a73c9d40
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
surfsense_web/app/(home)/changelog/page.tsx
View file

@ -29,7 +29,7 @@ interface ChangelogPageItem {
export default async function ChangelogPage() { export default async function ChangelogPage() {
const allPages = source.getPages() as ChangelogPageItem[]; const allPages = source.getPages() as ChangelogPageItem[];
const sortedChangelogs = allPages.sort((a, b) => { const sortedChangelogs = allPages.toSorted((a, b) => {
const dateA = new Date(a.data.date).getTime(); const dateA = new Date(a.data.date).getTime();
const dateB = new Date(b.data.date).getTime(); const dateB = new Date(b.data.date).getTime();
return dateB - dateA; return dateB - dateA;

4
surfsense_web/hooks/use-comments-sync.ts
View file

@ -118,8 +118,8 @@ function transformComments(
for (const [messageId, group] of byMessage) { for (const [messageId, group] of byMessage) {
const comments: Comment[] = group.topLevel.map((raw) => { const comments: Comment[] = group.topLevel.map((raw) => {
const replies = (group.replies.get(raw.id) || []) const replies = (group.replies.get(raw.id) ?? [])
.sort((a, b) => new Date(a.created_at).getTime() - new Date(b.created_at).getTime()) .toSorted((a, b) => new Date(a.created_at).getTime() - new Date(b.created_at).getTime())
.map((r) => transformReply(r, memberMap, currentUserId, isOwner)); .map((r) => transformReply(r, memberMap, currentUserId, isOwner));
return { return {