apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-04-25 00:36:31 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #1288 from MODSetter/dev

Browse source 
refactor: remove Azure OIDC token fetching steps from desktop release
This commit is contained in:
Rohan Verma 2026-04-21 10:58:56 -07:00 • committed by GitHub
commit c1754e409a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

26
.github/workflows/desktop-release.yml vendored
View file

@ -75,24 +75,6 @@ jobs:
echo "Windows signing: skipped"
fi
- name: Azure login (for Windows signing)
if: steps.sign.outputs.enabled == 'true'
uses: azure/login@v2
with:
client-id: ${{ secrets.AZURE_CLIENT_ID }}
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
- name: Fetch GitHub OIDC token for Azure signing SDK
if: steps.sign.outputs.enabled == 'true'
id: oidc
shell: pwsh
run: |
$token = (Invoke-RestMethod -Headers @{Authorization = "bearer $env:ACTIONS_ID_TOKEN_REQUEST_TOKEN"} `
-Uri "$env:ACTIONS_ID_TOKEN_REQUEST_URL&audience=api://AzureADTokenExchange").value
Write-Output "::add-mask::$token"
"token=$token" | Out-File -FilePath $env:GITHUB_OUTPUT -Encoding utf8 -Append
- name: Setup pnpm
uses: pnpm/action-setup@v5
@ -154,8 +136,10 @@ jobs:
AZURE_CODESIGN_ENDPOINT: ${{ vars.AZURE_CODESIGN_ENDPOINT }}
AZURE_CODESIGN_ACCOUNT: ${{ vars.AZURE_CODESIGN_ACCOUNT }}
AZURE_CODESIGN_PROFILE: ${{ vars.AZURE_CODESIGN_PROFILE }}
# Env vars for Azure.Identity EnvironmentCredential used by the TrustedSigning PowerShell module.
# Only populated when signing is enabled; harmless when empty otherwise.
# Service principal credentials for Azure.Identity EnvironmentCredential used by the
# TrustedSigning PowerShell module. Only populated when signing is enabled.
# electron-builder 26 does not yet support OIDC federated tokens for Azure signing,
# so we fall back to client-secret auth. Rotate AZURE_CLIENT_SECRET before expiry.
AZURE_TENANT_ID: ${{ steps.sign.outputs.enabled == 'true' && secrets.AZURE_TENANT_ID || '' }}
AZURE_CLIENT_ID: ${{ steps.sign.outputs.enabled == 'true' && secrets.AZURE_CLIENT_ID || '' }}
AZURE_FEDERATED_TOKEN: ${{ steps.oidc.outputs.token }}
AZURE_CLIENT_SECRET: ${{ steps.sign.outputs.enabled == 'true' && secrets.AZURE_CLIENT_SECRET || '' }}