apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-05 05:42:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Merge pull request #1322 from guangyang1206/perf/blog-search-derive-results-usememo
Some checks are pending
Build and Push Docker Images / tag_release (push) Waiting to run
Details
Build and Push Docker Images / build (./surfsense_backend, ./surfsense_backend/Dockerfile, backend, surfsense-backend, ubuntu-24.04-arm, linux/arm64, arm64) (push) Blocked by required conditions
Details
Build and Push Docker Images / build (./surfsense_backend, ./surfsense_backend/Dockerfile, backend, surfsense-backend, ubuntu-latest, linux/amd64, amd64) (push) Blocked by required conditions
Details
Build and Push Docker Images / build (./surfsense_web, ./surfsense_web/Dockerfile, web, surfsense-web, ubuntu-24.04-arm, linux/arm64, arm64) (push) Blocked by required conditions
Details
Build and Push Docker Images / build (./surfsense_web, ./surfsense_web/Dockerfile, web, surfsense-web, ubuntu-latest, linux/amd64, amd64) (push) Blocked by required conditions
Details
Build and Push Docker Images / create_manifest (backend, surfsense-backend) (push) Blocked by required conditions
Details
Build and Push Docker Images / create_manifest (web, surfsense-web) (push) Blocked by required conditions
Details

Browse source 
perf(blog): derive search results with useMemo instead of useState+us…
This commit is contained in:
Rohan Verma 2026-04-29 00:08:49 -07:00 • committed by GitHub
commit afb4b09cde
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
surfsense_web/app/(home)/blog/blog-magazine.tsx
View file

@ -3,7 +3,7 @@
import { format } from "date-fns"; import { format } from "date-fns";
import FuzzySearch from "fuzzy-search"; import FuzzySearch from "fuzzy-search";
import Link from "next/link"; import Link from "next/link";
import { useEffect, useMemo, useState } from "react"; import { useMemo, useState } from "react";
import { Container } from "@/components/container"; import { Container } from "@/components/container";
import type { BlogEntry } from "./page"; import type { BlogEntry } from "./page";
@ -127,17 +127,13 @@ function MagazineSearchGrid({
[allBlogs] [allBlogs]
); );
const [results, setResults] = useState(allBlogs);
useEffect(() => {
setResults(searcher.search(search));
}, [search, searcher]);
const gridItems = useMemo(() => { const gridItems = useMemo(() => {
const results = search.trim() ? searcher.search(search) : allBlogs;
if (search.trim()) { if (search.trim()) {
return results; return results;
} }
return results.filter((b) => b.slug !== featuredSlug); return results.filter((b) => b.slug !== featuredSlug);
}, [results, search, featuredSlug]); }, [search, searcher, allBlogs, featuredSlug]);
return ( return (
<section aria-labelledby="archive-heading"> <section aria-labelledby="archive-heading">