apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-25 19:15:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor: extract shared hasPermission helper (MODSetter/SurfSense#1366)

Browse source 
- Add canPerform() helper function to members-query.atoms.ts
- Add usePermissionGate() hook for convenience
- Update team-content.tsx to use canPerform()
- Update roles-manager.tsx to use canPerform()
- Eliminates duplicated permission check logic
- Centralizes permission policy in one location

Fixes #1366
This commit is contained in:
guangyang1206 2026-05-22 12:08:00 +08:00
parent 334729754f
commit a66d65a835
3 changed files with 41 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

5
surfsense_web/components/settings/roles-manager.tsx
View file

@ -26,7 +26,7 @@ import {
} from "lucide-react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { toast } from "sonner";
import { myAccessAtom } from "@/atoms/members/members-query.atoms";
import { myAccessAtom, canPerform } from "@/atoms/members/members-query.atoms";
import { permissionsAtom } from "@/atoms/permissions/permissions-query.atoms";
import {
createRoleMutationAtom,
@ -257,6 +257,9 @@ export function RolesManager({ searchSpaceId }: { searchSpaceId: number }) {
const { data: access = null } = useAtomValue(myAccessAtom);
const hasPermission = useCallback(
(permission: string) => canPerform(access, permission),
[access]
);
(permission: string) => {
if (!access) return false;
if (access.is_owner) return true;