apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-06-24 21:38:09 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(image-gen): resolve relative URLs returned by Xinference and compatible backends

Browse source 
Some OpenAI-compatible image backends (e.g. Xinference) return a relative
URL like /files/image.png in data[0].url instead of an absolute one.
Browsers cannot resolve these, causing images to fail to load.

Track the provider's api_base after resolving model config via to_litellm().
When the returned URL starts with "/", extract the origin (scheme + host + port)
from api_base and prepend it to produce a full absolute URL.

No behaviour change for providers that return absolute URLs (OpenAI, Azure, etc).

Closes #1496
This commit is contained in:
okxint 2026-06-17 10:57:39 +05:30
parent a49103870b
commit a12cd21f2f
1 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
surfsense_backend/app/agents/chat/multi_agent_chat/subagents/builtins/deliverables/tools/generate_image.py
View file

@ -143,6 +143,8 @@ def create_generate_image_tool(
choose_auto_model_candidate(candidates, search_space_id)["id"] choose_auto_model_candidate(candidates, search_space_id)["id"]
) )
provider_base_url: str | None = None
if config_id < 0: if config_id < 0:
global_model = _get_global_model(config_id) global_model = _get_global_model(config_id)
if not global_model or not has_capability( if not global_model or not has_capability(
@ -162,6 +164,7 @@ def create_generate_image_tool(
global_model["model_id"], global_model["model_id"],
) )
gen_kwargs.update(resolved_kwargs) gen_kwargs.update(resolved_kwargs)
provider_base_url = resolved_kwargs.get("api_base")
response = await aimage_generation( response = await aimage_generation(
prompt=prompt, model=model_string, **gen_kwargs prompt=prompt, model=model_string, **gen_kwargs
@ -203,6 +206,7 @@ def create_generate_image_tool(
db_model.model_id, db_model.model_id,
) )
gen_kwargs.update(resolved_kwargs) gen_kwargs.update(resolved_kwargs)
provider_base_url = resolved_kwargs.get("api_base")
response = await aimage_generation( response = await aimage_generation(
prompt=prompt, model=model_string, **gen_kwargs prompt=prompt, model=model_string, **gen_kwargs
@ -241,8 +245,19 @@ def create_generate_image_tool(
# b64_json (e.g. gpt-image-1) is served via our backend endpoint so # b64_json (e.g. gpt-image-1) is served via our backend endpoint so
# megabytes of base64 don't bloat the LLM context. # megabytes of base64 don't bloat the LLM context.
# Some OpenAI-compatible backends (e.g. Xinference) return a relative
# URL like /files/image.png. Browsers can't resolve these, so we
# prepend the provider's base origin when the URL starts with "/".
if first_image.get("url"): if first_image.get("url"):
image_url = first_image["url"] raw_url: str = first_image["url"]
if raw_url.startswith("/") and provider_base_url:
from urllib.parse import urlparse
parsed = urlparse(provider_base_url)
origin = f"{parsed.scheme}://{parsed.netloc}"
image_url = f"{origin}{raw_url}"
else:
image_url = raw_url
elif first_image.get("b64_json"): elif first_image.get("b64_json"):
backend_url = config.BACKEND_URL or "http://localhost:8000" backend_url = config.BACKEND_URL or "http://localhost:8000"
image_url = ( image_url = (