apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-04-29 02:46:25 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor: improve type safety in document extraction and UI components

Browse source 
- Introduced Zod schemas for type-safe parsing of mentioned document information in chat messages.
- Updated the extractMentionedDocuments function to utilize the new schemas for better validation.
- Made the 'alt' property optional in image-related components for improved flexibility and fallback handling.
This commit is contained in:
Anish Sarkar 2025-12-26 00:18:47 +05:30
parent bea18960a4
commit 9bc3f193c3
3 changed files with 29 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
surfsense_web/components/tool-ui/display-image.tsx
View file

@ -23,7 +23,7 @@ interface DisplayImageResult {
id: string;
assetId: string;
src: string;
alt?: string; // Made optional - parseSerializableImage provides fallback
alt?: string; // Made optional - parseSerializableImage provides fallback
title?: string;
description?: string;
domain?: string;

10
surfsense_web/components/tool-ui/image/index.tsx
View file

@ -24,7 +24,7 @@ const SerializableImageSchema = z.object({
id: z.string(),
assetId: z.string(),
src: z.string(),
alt: z.string().nullish(), // Made optional - will use fallback if missing
alt: z.string().nullish(), // Made optional - will use fallback if missing
title: z.string().nullish(),
description: z.string().nullish(),
href: z.string().nullish(),
@ -48,7 +48,7 @@ export interface ImageProps {
id: string;
assetId: string;
src: string;
alt?: string; // Optional with default fallback
alt?: string; // Optional with default fallback
title?: string;
description?: string;
href?: string;
@ -69,10 +69,10 @@ export function parseSerializableImage(result: unknown): SerializableImage & { a
if (!parsed.success) {
console.warn("Invalid image data:", parsed.error.issues);
// Try to extract basic info and return a fallback object
const obj = (result && typeof result === "object" ? result : {}) as Record<string, unknown>;
// If we have at least id, assetId, and src, we can still render the image
if (
typeof obj.id === "string" &&
@ -92,7 +92,7 @@ export function parseSerializableImage(result: unknown): SerializableImage & { a
source: undefined,
};
}
throw new Error(`Invalid image: ${parsed.error.issues.map((i) => i.message).join(", ")}`);
}