From f0a51fad6fbde21586c751b2da40b3b8f124d12f Mon Sep 17 00:00:00 2001 From: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Date: Fri, 15 May 2026 09:06:42 -0700 Subject: [PATCH] docs(editor): align PlateEditor onSave JSDoc with Mod+Shift+S chord Per #1373, the registered save chord is Mod+Shift+S (not Mod+S, which collides with the browser's Save-Page-As). The JSDoc on PlateEditorProps.onSave still claims Mod+S, which is misleading for downstream consumers of the component. Update the JSDoc to match the actual chord and call out why. Targeting dev per maintainer request. --- surfsense_web/components/editor/plate-editor.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/surfsense_web/components/editor/plate-editor.tsx b/surfsense_web/components/editor/plate-editor.tsx index 77845ad2a..348d1006f 100644 --- a/surfsense_web/components/editor/plate-editor.tsx +++ b/surfsense_web/components/editor/plate-editor.tsx @@ -42,7 +42,7 @@ export interface PlateEditorProps { editorVariant?: "default" | "demo" | "fullWidth" | "none"; /** Additional className for the container */ className?: string; - /** Save callback. When provided, ⌘+S / Ctrl+S shortcut is registered and save button appears. */ + /** Save callback. When provided, ⌘+Shift+S / Ctrl+Shift+S shortcut is registered (avoiding the browser's ⌘+S / Ctrl+S "Save Page As" conflict) and a save button appears in the toolbar. */ onSave?: () => void; /** Whether there are unsaved changes */ hasUnsavedChanges?: boolean;