apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-07 14:52:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: improve status handling and user feedback in SurfSense plugin

Browse source 
- Added refreshStatus method to update connection status immediately after settings changes.
- Enhanced error reporting with reportAuthError method for better authentication feedback.
- Updated status visuals in the status modal to reflect the new centralized structure.
- Improved connection handling in the settings tab to ensure accurate status representation.
This commit is contained in:
Anish Sarkar 2026-04-25 03:24:17 +05:30
parent 4f1c870987
commit 937965b335
5 changed files with 30 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

33
surfsense_obsidian/src/sync-engine.ts
View file

@ -71,6 +71,7 @@ export class SyncEngine {
private idleReconcileStreak = 0;
/** 2^streak is capped at this value (e.g. 8 → max ×8 backoff). */
private readonly maxBackoffMultiplier = 8;
private lastAppliedKind: StatusKind = "needs-setup";
constructor(deps: SyncEngineDeps) {
this.deps = deps;
@ -502,24 +503,38 @@ export class SyncEngine {
// ---- status helpers ---------------------------------------------------
/**
* Recomputes status from settings + queue depth. Call from main.ts after
* settings change so the indicator reacts to token paste / search-space
* pick without waiting for the next sync trigger.
* Conservative by default: real errors are preserved while setup is
* complete, so unrelated edits don't optimistically clear the indicator.
* Pass `force: true` after an explicit verify/reconcile confirmation.
*/
refreshStatus(): void {
refreshStatus(opts: { force?: boolean } = {}): void {
if (!opts.force) {
const last = this.lastAppliedKind;
const isError =
last === "auth-error" || last === "offline" || last === "error";
const s = this.deps.getSettings();
const setupComplete = !!(s.apiToken && s.searchSpaceId && s.connectorId);
if (isError && setupComplete) return;
}
this.setStatus(this.queueStatusKind(), this.statusDetail());
}
reportAuthError(message?: string): void {
this.setStatus("auth-error", message ?? "API token expired or invalid");
}
private setStatus(kind: StatusKind, detail?: string): void {
// Errors carry meaningful signal; only "happy" kinds get downgraded
// to needs-setup when prerequisites are missing.
if (kind !== "auth-error" && kind !== "offline" && kind !== "error") {
const s = this.deps.getSettings();
if (!s.apiToken || !s.searchSpaceId || !s.connectorId) {
const s = this.deps.getSettings();
if (!s.apiToken) {
kind = "needs-setup";
detail = this.setupHint(s);
} else if (kind !== "auth-error" && kind !== "offline" && kind !== "error") {
if (!s.searchSpaceId || !s.connectorId) {
kind = "needs-setup";
detail = this.setupHint(s);
}
}
this.lastAppliedKind = kind;
this.deps.setStatus({ kind, detail, queueDepth: this.deps.queue.size });
}