apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-31 19:45:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

feat(automations): add EVENT to TriggerType enum

Browse source
This commit is contained in:
CREDO23 2026-05-29 17:48:39 +02:00
parent d6dfe53d62
commit 9247a2337f
2 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
surfsense_backend/app/automations/persistence/enums/trigger_type.py
View file

@ -1,8 +1,8 @@
"""Trigger-kind discriminator. """Trigger-kind discriminator.
v1 only registers ``schedule``. ``manual`` is reserved in the enum (mirrors the ``schedule`` and ``event`` are registered. ``manual`` is reserved in the enum
postgres enum) but is intentionally unregistered pending a redesign of the (mirrors the postgres enum) but is intentionally unregistered pending a redesign
"Run now" UX. of the "Run now" UX.
""" """
from __future__ import annotations from __future__ import annotations
@ -12,4 +12,5 @@ from enum import StrEnum
class TriggerType(StrEnum): class TriggerType(StrEnum):
SCHEDULE = "schedule" SCHEDULE = "schedule"
EVENT = "event"
MANUAL = "manual" MANUAL = "manual"

8
surfsense_backend/tests/unit/automations/test_persistence_enums.py
View file

@ -39,7 +39,7 @@ def test_run_status_string_values_are_stable() -> None:
def test_trigger_type_keeps_manual_member_even_though_unregistered() -> None: def test_trigger_type_keeps_manual_member_even_though_unregistered() -> None:
"""``MANUAL`` is reserved (mirrors the Postgres enum) but the trigger """``schedule`` and ``event`` are registered; ``MANUAL`` is reserved
store does not register it in v1. The enum must keep both members so (mirrors the Postgres enum) but the trigger store does not register it.
existing DB rows and the schema migration plan stay valid.""" The enum must keep every member so DB rows and migrations stay valid."""
assert {member.value for member in TriggerType} == {"schedule", "manual"} assert {member.value for member in TriggerType} == {"schedule", "event", "manual"}