refactor(agents): move permissions to app/agents/shared (slice 4a)

Relocate the permission evaluator (wildcard matcher + rule evaluation) to the
shared kernel and flip 43 non-frozen importers. A re-export shim remains at
new_chat/permissions.py for the frozen single-agent stack (chat_deepagent and
subagents/{config,providers/linear,providers/slack}); it will be removed when
that stack is retired.
This commit is contained in:
CREDO23 2026-06-04 12:38:30 +02:00
parent 3efe51e6ec
commit 8fca2753aa
45 changed files with 260 additions and 231 deletions

View file

@ -13,7 +13,7 @@ from app.agents.multi_agent_chat.subagents.shared.hitl.wire import (
SURFSENSE_DECISION_APPROVE_ALWAYS,
build_lc_hitl_payload,
)
from app.agents.new_chat.permissions import Rule
from app.agents.shared.permissions import Rule
PERMISSION_ASK_INTERRUPT_TYPE = "permission_ask"

View file

@ -16,7 +16,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from langgraph.types import interrupt
from app.agents.new_chat.permissions import Rule
from app.agents.shared.permissions import Rule
from app.observability import metrics as ot_metrics, otel as ot
from .decision import normalize_permission_decision

View file

@ -12,7 +12,7 @@ from typing import Any
from langchain_core.messages import ToolMessage
from app.agents.shared.errors import StreamingError
from app.agents.new_chat.permissions import Rule
from app.agents.shared.permissions import Rule
def build_deny_message(tool_call: dict[str, Any], rule: Rule) -> ToolMessage:

View file

@ -27,7 +27,7 @@ from langchain_core.tools import BaseTool
from langgraph.runtime import Runtime
from app.agents.shared.errors import CorrectedError, RejectedError
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from app.services.user_tool_allowlist import TrustedToolSaver
from ..ask.edit import merge_edited_args

View file

@ -16,7 +16,7 @@ from __future__ import annotations
import logging
from typing import Any
from app.agents.new_chat.permissions import (
from app.agents.shared.permissions import (
Rule,
RuleAction,
Ruleset,

View file

@ -28,7 +28,7 @@ from collections.abc import Sequence
from langchain_core.tools import BaseTool
from app.agents.shared.feature_flags import AgentFeatureFlags
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
from app.services.user_tool_allowlist import TrustedToolSaver
from .core import PermissionMiddleware

View file

@ -9,7 +9,7 @@ newly-promoted rules apply to subsequent calls.
from __future__ import annotations
from app.agents.new_chat.permissions import Ruleset, aggregate_action, evaluate_many
from app.agents.shared.permissions import Ruleset, aggregate_action, evaluate_many
def all_rulesets(

View file

@ -7,7 +7,7 @@ is the streaming layer's job — this module keeps the in-memory copy only.
from __future__ import annotations
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
def persist_always(

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .generate_image import create_generate_image_tool
from .podcast import create_generate_podcast_tool

View file

@ -15,7 +15,7 @@ from langchain_core.tools import BaseTool
from app.agents.multi_agent_chat.subagents.shared.spec import SurfSenseSubagentSpec
from app.agents.shared.filesystem_selection import FilesystemMode
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
from .middleware_stack import build_kb_middleware
from .prompts import load_description, load_readonly_system_prompt, load_system_prompt

View file

@ -30,7 +30,7 @@ from app.agents.multi_agent_chat.middleware.shared.permissions import (
)
from app.agents.shared.feature_flags import AgentFeatureFlags
from app.agents.shared.filesystem_selection import FilesystemMode
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
def _kb_user_allowlist(

View file

@ -6,7 +6,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from app.db import ChatVisibility
from .update_memory import create_update_memory_tool, create_update_team_memory_tool

View file

@ -6,7 +6,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .scrape_webpage import create_scrape_webpage_tool
from .web_search import create_web_search_tool

View file

@ -2,7 +2,7 @@
from __future__ import annotations
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
NAME = "airtable"

View file

@ -10,7 +10,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_event import create_create_calendar_event_tool
from .delete_event import create_delete_calendar_event_tool

View file

@ -2,7 +2,7 @@
from __future__ import annotations
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
NAME = "clickup"

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_page import create_create_confluence_page_tool
from .delete_page import create_delete_confluence_page_tool

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .list_channels import create_list_discord_channels_tool
from .read_messages import create_read_discord_messages_tool

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_file import create_create_dropbox_file_tool
from .trash_file import create_delete_dropbox_file_tool

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_draft import create_create_gmail_draft_tool
from .read_email import create_read_gmail_email_tool

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_file import create_create_google_drive_file_tool
from .trash_file import create_delete_google_drive_file_tool

View file

@ -2,7 +2,7 @@
from __future__ import annotations
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
NAME = "jira"

View file

@ -2,7 +2,7 @@
from __future__ import annotations
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
NAME = "linear"

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_event import create_create_luma_event_tool
from .list_events import create_list_luma_events_tool

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_page import create_create_notion_page_tool
from .delete_page import create_delete_notion_page_tool

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .create_file import create_create_onedrive_file_tool
from .trash_file import create_delete_onedrive_file_tool

View file

@ -2,7 +2,7 @@
from __future__ import annotations
from app.agents.new_chat.permissions import Rule, Ruleset
from app.agents.shared.permissions import Rule, Ruleset
NAME = "slack"

View file

@ -9,7 +9,7 @@ from typing import Any
from langchain_core.tools import BaseTool
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
from .list_channels import create_list_teams_channels_tool
from .read_messages import create_read_teams_messages_tool

View file

@ -8,7 +8,7 @@ from typing import Any
from deepagents import SubAgent
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
# A context-hint provider receives the parent-agent ``runtime.state`` mapping
# and the ``description`` the orchestrator wrote, and returns a short string

View file

@ -22,7 +22,7 @@ from app.agents.multi_agent_chat.subagents.shared.spec import (
ContextHintProvider,
SurfSenseSubagentSpec,
)
from app.agents.new_chat.permissions import Ruleset
from app.agents.shared.permissions import Ruleset
logger = logging.getLogger(__name__)