apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-04-30 19:36:25 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: add cancelAnimationFrame cleanup in animated-tabs useEffect

Browse source 
Store the requestAnimationFrame ID and cancel it on unmount
to prevent updateActiveIndicator from running on an unmounted
component.

Fixes #1093
This commit is contained in:
Matt Van Horn 2026-04-08 01:39:14 -07:00
parent 553843ab06
commit 833ea18800
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
surfsense_web/components/ui/animated-tabs.tsx
View file

@ -310,7 +310,8 @@ const TabsList = forwardRef<
}, [updateActiveIndicator]); }, [updateActiveIndicator]);
useEffect(() => { useEffect(() => {
requestAnimationFrame(updateActiveIndicator); const id = requestAnimationFrame(updateActiveIndicator);
return () => cancelAnimationFrame(id);
}, [updateActiveIndicator]); }, [updateActiveIndicator]);
const scrollTabToCenter = useCallback((index: number) => { const scrollTabToCenter = useCallback((index: number) => {