From 72c2dd0e1b6cbf9d9bb9072b12c6cc9c3218d8b2 Mon Sep 17 00:00:00 2001 From: Anish Sarkar <104695310+AnishSarkar22@users.noreply.github.com> Date: Mon, 6 Jul 2026 10:40:49 +0530 Subject: [PATCH] refactor(team): streamline TeamPage function parameters and improve layout constraints - Simplified the TeamPage function parameter destructuring for better readability. - Updated LayoutDataProvider to increase maximum width for specific pages, enhancing layout consistency. - Adjusted ZeroProvider state management to use undefined instead of null for clarity in context handling. --- .../app/dashboard/[workspace_id]/team/page.tsx | 6 +----- .../layout/providers/LayoutDataProvider.tsx | 2 +- surfsense_web/components/providers/ZeroProvider.tsx | 11 +++++------ 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/surfsense_web/app/dashboard/[workspace_id]/team/page.tsx b/surfsense_web/app/dashboard/[workspace_id]/team/page.tsx index 4f986b287..c81646e4c 100644 --- a/surfsense_web/app/dashboard/[workspace_id]/team/page.tsx +++ b/surfsense_web/app/dashboard/[workspace_id]/team/page.tsx @@ -1,10 +1,6 @@ import { TeamContent } from "./team-content"; -export default async function TeamPage({ - params, -}: { - params: Promise<{ workspace_id: string }>; -}) { +export default async function TeamPage({ params }: { params: Promise<{ workspace_id: string }> }) { const { workspace_id } = await params; return ( diff --git a/surfsense_web/components/layout/providers/LayoutDataProvider.tsx b/surfsense_web/components/layout/providers/LayoutDataProvider.tsx index f41e318d4..2624384d3 100644 --- a/surfsense_web/components/layout/providers/LayoutDataProvider.tsx +++ b/surfsense_web/components/layout/providers/LayoutDataProvider.tsx @@ -776,7 +776,7 @@ export function LayoutDataProvider({ searchSpaceId, children }: LayoutDataProvid isAutomationsPage ? "max-w-none select-none" : isAllChatsPage - ? "max-w-3xl" + ? "max-w-5xl" : isUserSettingsPage || isSearchSpaceSettingsPage || isTeamPage ? "max-w-5xl" : undefined diff --git a/surfsense_web/components/providers/ZeroProvider.tsx b/surfsense_web/components/providers/ZeroProvider.tsx index cfb8fe586..e29effda8 100644 --- a/surfsense_web/components/providers/ZeroProvider.tsx +++ b/surfsense_web/components/providers/ZeroProvider.tsx @@ -21,6 +21,7 @@ type LoadedZeroContext = { context: ZeroContext; desktopAuth?: string; }; +type ZeroContextState = LoadedZeroContext | null | undefined; function getCacheURL() { if (configuredCacheURL) return configuredCacheURL; @@ -131,7 +132,7 @@ function AuthenticatedZeroProvider({ children: React.ReactNode; isDesktop: boolean; }) { - const [loadedContext, setLoadedContext] = useState(null); + const [loadedContext, setLoadedContext] = useState(undefined); useEffect(() => { let isMounted = true; @@ -153,7 +154,7 @@ function AuthenticatedZeroProvider({ const unsubscribe = window.electronAPI.onAuthChanged(({ accessToken }) => { if (!accessToken) { - setLoadedContext(null); + setLoadedContext(undefined); return; } void load(); @@ -165,9 +166,7 @@ function AuthenticatedZeroProvider({ }; }, [isDesktop]); - if (!loadedContext) { - return <>{children}; - } + if (!loadedContext) return null; return ( {children}; + return null; } return {children};