apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-07-20 23:21:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor: improve type safety for use-comments.ts

Browse source 
- Updated the `resetBatchGate` function to accept a parameter for immediate resolution, enhancing batch processing control.
- Changed the return type of the `useQuery` hook in `useComments` to specify `GetCommentsResponse`, improving type safety and clarity.
- Adjusted the initial batch gate invocation to resolve immediately, streamlining the comments fetching process.
This commit is contained in:
Anish Sarkar 2026-03-01 22:58:02 +05:30
parent 6d00b0debf
commit 6de6684f81
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
surfsense_web/hooks/use-comments.ts
View file

@ -1,5 +1,6 @@
import { useQuery, useQueryClient } from "@tanstack/react-query"; import { useQuery, useQueryClient } from "@tanstack/react-query";
import { useEffect, useRef } from "react"; import { useEffect, useRef } from "react";
import type { GetCommentsResponse } from "@/contracts/types/chat-comments.types";
import { chatCommentsApiService } from "@/lib/apis/chat-comments-api.service"; import { chatCommentsApiService } from "@/lib/apis/chat-comments-api.service";
import { cacheKeys } from "@/lib/query-client/cache-keys"; import { cacheKeys } from "@/lib/query-client/cache-keys";
@ -22,20 +23,20 @@ let _batchTargetIds = new Set<number>();
let _batchReady: Promise<void> | null = null; let _batchReady: Promise<void> | null = null;
let _resolveBatchReady: (() => void) | null = null; let _resolveBatchReady: (() => void) | null = null;
function resetBatchGate() { function resetBatchGate(resolveImmediately = false) {
_batchReady = new Promise<void>((r) => { _batchReady = new Promise<void>((r) => {
_resolveBatchReady = r; _resolveBatchReady = r;
if (resolveImmediately) r();
}); });
} }
// Open the initial gate immediately (no batch pending yet) // Open the initial gate immediately (no batch pending yet)
resetBatchGate(); resetBatchGate(true);
_resolveBatchReady?.();
export function useComments({ messageId, enabled = true }: UseCommentsOptions) { export function useComments({ messageId, enabled = true }: UseCommentsOptions) {
const queryClient = useQueryClient(); const queryClient = useQueryClient();
return useQuery({ return useQuery<GetCommentsResponse>({
queryKey: cacheKeys.comments.byMessage(messageId), queryKey: cacheKeys.comments.byMessage(messageId),
queryFn: async () => { queryFn: async () => {
// Wait for the batch gate so the useEffect in useBatchCommentsPreload // Wait for the batch gate so the useEffect in useBatchCommentsPreload
@ -46,7 +47,7 @@ export function useComments({ messageId, enabled = true }: UseCommentsOptions) {
if (_batchInflight && _batchTargetIds.has(messageId)) { if (_batchInflight && _batchTargetIds.has(messageId)) {
await _batchInflight; await _batchInflight;
const cached = queryClient.getQueryData(cacheKeys.comments.byMessage(messageId)); const cached = queryClient.getQueryData<GetCommentsResponse>(cacheKeys.comments.byMessage(messageId));
if (cached) return cached; if (cached) return cached;
} }