From 017c2628425970c9c9beaebc88f6ccceb79be4ad Mon Sep 17 00:00:00 2001
From: "DESKTOP-RTLN3BA\\$punk" <vermarohanfinal@gmail.com>
Date: Thu, 5 Feb 2026 23:45:01 -0800
Subject: [PATCH] fix: update DocumentsFilters component for accessibility and
 add success message for document deletion

---
 .../(manage)/components/DocumentsFilters.tsx        | 13 ++++++++++---
 surfsense_web/messages/en.json                      |  1 +
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsx b/surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsx
index 6bd5f8460..ebdf431e4 100644
--- a/surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsx
+++ b/surfsense_web/app/dashboard/[search_space_id]/documents/(manage)/components/DocumentsFilters.tsx
@@ -193,11 +193,18 @@ export function DocumentsFilters({
 										</div>
 									) : (
 										filteredTypes.map((value: DocumentTypeEnum, i) => (
-											<button
+											<div
 												key={value}
-												type="button"
+												role="button"
+												tabIndex={0}
 												className="flex w-full items-center gap-2.5 py-2 px-3 rounded-md hover:bg-muted/50 transition-colors cursor-pointer text-left"
 												onClick={() => onToggleType(value, !activeTypes.includes(value))}
+												onKeyDown={(e) => {
+													if (e.key === "Enter" || e.key === " ") {
+														e.preventDefault();
+														onToggleType(value, !activeTypes.includes(value));
+													}
+												}}
 											>
 												{/* Icon */}
 												<div className="flex h-7 w-7 shrink-0 items-center justify-center rounded-md bg-muted/50 text-foreground/80">
@@ -220,7 +227,7 @@ export function DocumentsFilters({
 													onCheckedChange={(checked: boolean) => onToggleType(value, !!checked)}
 													className="h-4 w-4 shrink-0 rounded border-muted-foreground/30 data-[state=checked]:bg-primary data-[state=checked]:border-primary"
 												/>
-											</button>
+											</div>
 										))
 									)}
 								</div>
diff --git a/surfsense_web/messages/en.json b/surfsense_web/messages/en.json
index 68ea533ac..fae4c7265 100644
--- a/surfsense_web/messages/en.json
+++ b/surfsense_web/messages/en.json
@@ -308,6 +308,7 @@
 		"no_rows_selected": "No rows selected",
 		"delete_success_count": "Successfully deleted {count} document(s)",
 		"delete_partial_failed": "Some documents could not be deleted",
+		"delete_success": "Document deleted successfully",
 		"delete_error": "Error deleting documents",
 		"filter_by_title": "Filter by title...",
 		"bulk_delete": "Delete Selected",