mirror of
https://github.com/MODSetter/SurfSense.git
synced 2026-07-22 23:31:12 +02:00
fix: avoid blocking audio writes
TTS responses were written synchronously from the async presentation pipeline, blocking concurrent requests. Offload byte writes to a worker thread and add a regression test that keeps the event loop responsive.
This commit is contained in:
parent
32bb099025
commit
5cc05d90f0
3 changed files with 38 additions and 2 deletions
|
|
@ -17,6 +17,7 @@ from app.config import config as app_config
|
||||||
from app.services.kokoro_tts_service import get_kokoro_tts_service
|
from app.services.kokoro_tts_service import get_kokoro_tts_service
|
||||||
from app.services.llm_service import get_agent_llm
|
from app.services.llm_service import get_agent_llm
|
||||||
from app.utils.content_utils import extract_text_content, strip_markdown_fences
|
from app.utils.content_utils import extract_text_content, strip_markdown_fences
|
||||||
|
from app.utils.file_io import write_bytes
|
||||||
|
|
||||||
from .configuration import Configuration
|
from .configuration import Configuration
|
||||||
from .prompts import (
|
from .prompts import (
|
||||||
|
|
@ -137,8 +138,7 @@ async def create_slide_audio(state: State, config: RunnableConfig) -> dict[str,
|
||||||
kwargs["api_base"] = app_config.TTS_SERVICE_API_BASE
|
kwargs["api_base"] = app_config.TTS_SERVICE_API_BASE
|
||||||
|
|
||||||
response = await aspeech(**kwargs)
|
response = await aspeech(**kwargs)
|
||||||
with open(chunk_path, "wb") as f:
|
await write_bytes(chunk_path, response.content)
|
||||||
f.write(response.content)
|
|
||||||
|
|
||||||
return chunk_path
|
return chunk_path
|
||||||
|
|
||||||
|
|
|
||||||
7
surfsense_backend/app/utils/file_io.py
Normal file
7
surfsense_backend/app/utils/file_io.py
Normal file
|
|
@ -0,0 +1,7 @@
|
||||||
|
import asyncio
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
|
||||||
|
async def write_bytes(path: str, content: bytes) -> None:
|
||||||
|
"""Write bytes without blocking the event loop."""
|
||||||
|
await asyncio.to_thread(Path(path).write_bytes, content)
|
||||||
|
|
@ -0,0 +1,29 @@
|
||||||
|
import asyncio
|
||||||
|
import threading
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from app.utils.file_io import write_bytes
|
||||||
|
|
||||||
|
pytestmark = pytest.mark.unit
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.asyncio
|
||||||
|
async def test_write_bytes_does_not_block_event_loop(monkeypatch, tmp_path):
|
||||||
|
write_started = threading.Event()
|
||||||
|
release_write = threading.Event()
|
||||||
|
|
||||||
|
def blocking_write(_path, _content):
|
||||||
|
write_started.set()
|
||||||
|
release_write.wait(timeout=1)
|
||||||
|
return 5
|
||||||
|
|
||||||
|
monkeypatch.setattr("pathlib.Path.write_bytes", blocking_write)
|
||||||
|
|
||||||
|
task = asyncio.create_task(write_bytes(str(tmp_path / "audio.mp3"), b"audio"))
|
||||||
|
while not write_started.is_set():
|
||||||
|
await asyncio.sleep(0)
|
||||||
|
|
||||||
|
assert not task.done()
|
||||||
|
release_write.set()
|
||||||
|
await task
|
||||||
Loading…
Add table
Add a link
Reference in a new issue