apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-15 18:25:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

minor changes

Browse source
This commit is contained in:
Manoj Aggarwal 2026-01-13 21:17:37 -08:00
parent c78ea98a68
commit 5c22238c10
2 changed files with 63 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
surfsense_web/components/assistant-ui/connector-popup/connector-configs/components/mcp-config.tsx
View file

@ -123,6 +123,15 @@ export const MCPConfig: FC<MCPConfigProps> = ({ connector, onConfigChange, onNam
setJsonError(null); setJsonError(null);
} }
// Treat empty/whitespace-only input as empty array (user wants to remove all servers)
const trimmedValue = value.trim();
if (trimmedValue === "") {
if (onConfigChange) {
onConfigChange({ server_configs: [] });
}
return;
}
// Try to parse and update parent if valid // Try to parse and update parent if valid
try { try {
const parsed = JSON.parse(value); const parsed = JSON.parse(value);
@ -141,8 +150,9 @@ export const MCPConfig: FC<MCPConfigProps> = ({ connector, onConfigChange, onNam
} }
} }
// Update parent if we have valid configs // Always update parent with configs (including empty array)
if (validConfigs.length > 0 && onConfigChange) { // Empty array signals that all servers should be removed
if (onConfigChange) {
onConfigChange({ server_configs: validConfigs }); onConfigChange({ server_configs: validConfigs });
} }
} catch { } catch {

51
surfsense_web/components/assistant-ui/connector-popup/hooks/use-connector-dialog.ts
View file

@ -1047,6 +1047,57 @@ export const useConnectorDialog = () => {
const startDateStr = startDate ? format(startDate, "yyyy-MM-dd") : undefined; const startDateStr = startDate ? format(startDate, "yyyy-MM-dd") : undefined;
const endDateStr = endDate ? format(endDate, "yyyy-MM-dd") : undefined; const endDateStr = endDate ? format(endDate, "yyyy-MM-dd") : undefined;
// For MCP connectors, check if all servers were removed (empty array)
if (editingConnector.connector_type === "MCP_CONNECTOR") {
const serverConfigs = connectorConfig?.server_configs;
if (!serverConfigs || (Array.isArray(serverConfigs) && serverConfigs.length === 0)) {
// All servers removed - delete the entire connector
await deleteConnector({
id: editingConnector.id,
});
// Also delete other MCP connectors that were consolidated
if (otherMCPConnectorIds.length > 0) {
await Promise.all(
otherMCPConnectorIds.map((id) =>
deleteConnector({
id,
}).catch(() => {
// Silently ignore errors for individual deletions
})
)
);
setOtherMCPConnectorIds([]);
}
toast.success("MCPs disconnected successfully", {
description: "All MCP servers have been removed.",
});
// Update URL to close modal
const url = new URL(window.location.href);
url.searchParams.delete("modal");
url.searchParams.delete("tab");
url.searchParams.delete("view");
url.searchParams.delete("connectorId");
router.replace(url.pathname + url.search, { scroll: false });
// Refresh connectors and reset state
refreshConnectors();
setEditingConnector(null);
setConnectorName("");
setConnectorConfig(null);
setPeriodicEnabled(false);
setFrequencyMinutes("1440");
setStartDate(undefined);
setEndDate(undefined);
setOtherMCPConnectorIds([]);
setIsSaving(false);
return;
}
}
// For MCP connectors, delete other MCP connectors first (consolidate all into one) // For MCP connectors, delete other MCP connectors first (consolidate all into one)
if (editingConnector.connector_type === "MCP_CONNECTOR" && otherMCPConnectorIds.length > 0) { if (editingConnector.connector_type === "MCP_CONNECTOR" && otherMCPConnectorIds.length > 0) {
// Silently delete other MCP connectors without showing toasts // Silently delete other MCP connectors without showing toasts