apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-07-20 23:21:06 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(announcement-spotlight): simplify dismissal logic and update button style

Browse source
This commit is contained in:
Anish Sarkar 2026-07-14 01:02:22 +05:30
parent 9364f92c63
commit 527ce2d97b
1 changed files with 5 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

23
surfsense_web/components/announcements/AnnouncementSpotlight.tsx
View file

@ -20,14 +20,10 @@ import { useAnnouncements } from "@/hooks/use-announcements";
* Behaviour:
* - On load, the first active, audience-matched, unread spotlight announcement
* is shown automatically.
* - The user must explicitly acknowledge it ("Got it" or the CTA link), which
* marks it as read so it never shows again.
* - Closing via the X / Escape / outside-click only hides it for the current
* session; it reappears on the next load until the user marks it as seen.
* - Any dismissal marks it as read so it never shows again.
*/
export function AnnouncementSpotlight() {
const { announcements, markRead } = useAnnouncements();
const [sessionDismissed, setSessionDismissed] = useState<Set<string>>(() => new Set());
const [ready, setReady] = useState(false);
// Short delay so the spotlight doesn't flash during initial hydration/layout.
@ -37,11 +33,8 @@ export function AnnouncementSpotlight() {
}, []);
const current = useMemo(
() =>
announcements.find(
(a) => a.spotlight && a.isImportant && !a.isRead && !sessionDismissed.has(a.id)
) ?? null,
[announcements, sessionDismissed]
() => announcements.find((a) => a.spotlight && a.isImportant && !a.isRead) ?? null,
[announcements]
);
if (!current) return null;
@ -51,13 +44,7 @@ export function AnnouncementSpotlight() {
};
const handleOpenChange = (next: boolean) => {
if (!next) {
setSessionDismissed((prev) => {
const updated = new Set(prev);
updated.add(current.id);
return updated;
});
}
if (!next) markRead(current.id);
};
return (
@ -82,7 +69,7 @@ export function AnnouncementSpotlight() {
</DialogDescription>
<DialogFooter className="mt-2">
{current.link && (
<Button variant="outline" asChild className="gap-1.5" onClick={handleAcknowledge}>
<Button variant="secondary" asChild className="gap-1.5" onClick={handleAcknowledge}>
<Link
href={current.link.url}
target={current.link.url.startsWith("http") ? "_blank" : undefined}