apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-01 20:03:30 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: add input validation, retry limit, code formatting, and exclude i18n from secret detection

Browse source
This commit is contained in:
Differ 2025-12-05 09:58:49 +08:00
parent 6b1b8d0f2e
commit 500bc60d02
3 changed files with 38 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

22
surfsense_backend/app/tasks/connector_indexers/bookstack_indexer.py
View file

@ -87,7 +87,11 @@ async def index_bookstack_pages(
bookstack_token_id = connector.config.get("BOOKSTACK_TOKEN_ID")
bookstack_token_secret = connector.config.get("BOOKSTACK_TOKEN_SECRET")
if not bookstack_base_url or not bookstack_token_id or not bookstack_token_secret:
if (
not bookstack_base_url
or not bookstack_token_id
or not bookstack_token_secret
):
await task_logger.log_task_failure(
log_entry,
f"BookStack credentials not found in connector config for connector {connector_id}",
@ -196,9 +200,7 @@ async def index_bookstack_pages(
page_id, use_markdown=True
)
except Exception as e:
logger.warning(
f"Failed to fetch content for page {page_name}: {e}"
)
logger.warning(f"Failed to fetch content for page {page_name}: {e}")
skipped_pages.append(f"{page_name} (content fetch error)")
documents_skipped += 1
continue
@ -275,7 +277,9 @@ async def index_bookstack_pages(
full_content, user_llm, summary_metadata
)
else:
summary_content = f"BookStack Page: {page_name}\n\nBook ID: {book_id}\n\n"
summary_content = (
f"BookStack Page: {page_name}\n\nBook ID: {book_id}\n\n"
)
if page_content:
content_preview = page_content[:1000]
if len(page_content) > 1000:
@ -299,9 +303,7 @@ async def index_bookstack_pages(
existing_document.chunks = chunks
documents_indexed += 1
logger.info(
f"Successfully updated BookStack page {page_name}"
)
logger.info(f"Successfully updated BookStack page {page_name}")
continue
# Document doesn't exist - create new one
@ -388,9 +390,7 @@ async def index_bookstack_pages(
f"Final commit: Total {documents_indexed} BookStack pages processed"
)
await session.commit()
logger.info(
"Successfully committed all BookStack document changes to database"
)
logger.info("Successfully committed all BookStack document changes to database")
# Log success
await task_logger.log_task_success(