From 36391acfd067e16d4c71c36d2564fbd8bfb9fc14 Mon Sep 17 00:00:00 2001
From: SohamBhattacharjee2003
 <125297948+SohamBhattacharjee2003@users.noreply.github.com>
Date: Wed, 8 Apr 2026 04:58:14 +0530
Subject: [PATCH] fix: add autoComplete attributes to form inputs for better UX

- Add autoComplete="username" and "current-password" to login form
- Add autoComplete="email" and "new-password" to register form inputs
- Add autoComplete="name" to profile display name input
- Add autoComplete="off" to connector search input
- Enables browser password managers and autofill functionality
---
 surfsense_web/app/(home)/login/LocalLoginForm.tsx              | 2 ++
 surfsense_web/app/(home)/register/page.tsx                     | 3 +++
 .../user-settings/components/ProfileContent.tsx                | 1 +
 .../connector-popup/components/connector-dialog-header.tsx     | 1 +
 4 files changed, 7 insertions(+)

diff --git a/surfsense_web/app/(home)/login/LocalLoginForm.tsx b/surfsense_web/app/(home)/login/LocalLoginForm.tsx
index ee3b47683..c40e16915 100644
--- a/surfsense_web/app/(home)/login/LocalLoginForm.tsx
+++ b/surfsense_web/app/(home)/login/LocalLoginForm.tsx
@@ -156,6 +156,7 @@ export function LocalLoginForm() {
 					<input
 						id="email"
 						type="email"
+						autoComplete="username"
 						required
 						placeholder="you@example.com"
 						value={username}
@@ -177,6 +178,7 @@ export function LocalLoginForm() {
 						<input
 							id="password"
 							type={showPassword ? "text" : "password"}
+							autoComplete="current-password"
 							required
 							placeholder="Enter your password"
 							value={password}
diff --git a/surfsense_web/app/(home)/register/page.tsx b/surfsense_web/app/(home)/register/page.tsx
index 2d590d7cc..a1f4e6f0f 100644
--- a/surfsense_web/app/(home)/register/page.tsx
+++ b/surfsense_web/app/(home)/register/page.tsx
@@ -238,6 +238,7 @@ export default function RegisterPage() {
 							<input
 								id="email"
 								type="email"
+								autoComplete="email"
 								required
 								placeholder="you@example.com"
 								value={email}
@@ -261,6 +262,7 @@ export default function RegisterPage() {
 							<input
 								id="password"
 								type="password"
+								autoComplete="new-password"
 								required
 								placeholder="Enter your password"
 								value={password}
@@ -284,6 +286,7 @@ export default function RegisterPage() {
 							<input
 								id="confirmPassword"
 								type="password"
+								autoComplete="new-password"
 								required
 								placeholder="Confirm your password"
 								value={confirmPassword}
diff --git a/surfsense_web/app/dashboard/[search_space_id]/user-settings/components/ProfileContent.tsx b/surfsense_web/app/dashboard/[search_space_id]/user-settings/components/ProfileContent.tsx
index 3a3bc65fb..c1e81283b 100644
--- a/surfsense_web/app/dashboard/[search_space_id]/user-settings/components/ProfileContent.tsx
+++ b/surfsense_web/app/dashboard/[search_space_id]/user-settings/components/ProfileContent.tsx
@@ -93,6 +93,7 @@ export function ProfileContent() {
 								<Input
 									id="display-name"
 									type="text"
+									autoComplete="name"
 									placeholder={user?.email?.split("@")[0]}
 									value={displayName}
 									onChange={(e) => setDisplayName(e.target.value)}
diff --git a/surfsense_web/components/assistant-ui/connector-popup/components/connector-dialog-header.tsx b/surfsense_web/components/assistant-ui/connector-popup/components/connector-dialog-header.tsx
index 6bae69384..819e11cd3 100644
--- a/surfsense_web/components/assistant-ui/connector-popup/components/connector-dialog-header.tsx
+++ b/surfsense_web/components/assistant-ui/connector-popup/components/connector-dialog-header.tsx
@@ -66,6 +66,7 @@ export const ConnectorDialogHeader: FC<ConnectorDialogHeaderProps> = ({
 						<Search className="absolute left-3 top-1/2 -translate-y-1/2 size-4 text-gray-500 dark:text-gray-500" />
 						<input
 							type="text"
+							autoComplete="off"
 							placeholder="Search"
 							className={cn(
 								"w-full bg-slate-400/5 dark:bg-white/5 hover:bg-slate-400/10 dark:hover:bg-white/10 focus:bg-slate-400/10 dark:focus:bg-white/10 border border-border rounded-xl pl-9 py-2 text-sm transition-all outline-none placeholder:text-muted-foreground/50",