apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-27 19:25:15 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1038 from JoeMakuta/fix/narrow-effect-use-lazy-state-init-add-memo

Browse source 
fix : narrow effect, use lazy state init and add memo
This commit is contained in:
Rohan Verma 2026-03-30 15:22:44 -07:00 • committed by GitHub
commit 25b068f420
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 17 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
surfsense_web/components/settings/general-settings-manager.tsx
View file

@ -47,7 +47,7 @@ export function GeneralSettingsManager({ searchSpaceId }: GeneralSettingsManager
setName(searchSpace.name || "");
setDescription(searchSpace.description || "");
}
}, [searchSpace]);
}, [searchSpace?.name, searchSpace?.description]);
// Derive hasChanges during render
const hasChanges = !!searchSpace && ((searchSpace.name || "") !== name || (searchSpace.description || "") !== description);

6
surfsense_web/components/settings/llm-role-manager.tsx
View file

@ -112,11 +112,11 @@ export function LLMRoleManager({ searchSpaceId }: LLMRoleManagerProps) {
const { mutateAsync: updatePreferences } = useAtomValue(updateLLMPreferencesMutationAtom);
const [assignments, setAssignments] = useState({
const [assignments, setAssignments] = useState(() => ({
agent_llm_id: preferences.agent_llm_id ?? "",
document_summary_llm_id: preferences.document_summary_llm_id ?? "",
image_generation_config_id: preferences.image_generation_config_id ?? "",
});
}));
const [hasChanges, setHasChanges] = useState(false);
const [isSaving, setIsSaving] = useState(false);
@ -129,7 +129,7 @@ export function LLMRoleManager({ searchSpaceId }: LLMRoleManagerProps) {
};
setAssignments(newAssignments);
setHasChanges(false);
}, [preferences]);
}, [preferences?.agent_llm_id, preferences?.document_summary_llm_id, preferences?.image_generation_config_id]);
const handleRoleAssignment = (prefKey: string, configId: string) => {
const newAssignments = {

2
surfsense_web/components/settings/prompt-config-manager.tsx
View file

@ -38,7 +38,7 @@ export function PromptConfigManager({ searchSpaceId }: PromptConfigManagerProps)
if (searchSpace) {
setCustomInstructions(searchSpace.qna_custom_instructions || "");
}
}, [searchSpace]);
}, [searchSpace?.qna_custom_instructions]);
// Derive hasChanges during render
const hasChanges = !!searchSpace && (searchSpace.qna_custom_instructions || "") !== customInstructions;