Merge pull request #1255 from mvanhorn/osc/1249-remove-unused-scrolled-state-v2

fix(new-chat): remove unused _hasScrolledToCited state in source-detail-panel
This commit is contained in:
Rohan Verma 2026-04-17 13:34:04 -07:00 committed by GitHub
commit 2270b4c68a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -133,7 +133,6 @@ export function SourceDetailPanel({
const scrollTimersRef = useRef<ReturnType<typeof setTimeout>[]>([]);
const [activeChunkIndex, setActiveChunkIndex] = useState<number | null>(null);
const [mounted, setMounted] = useState(false);
const [_hasScrolledToCited, setHasScrolledToCited] = useState(false);
const shouldReduceMotion = useReducedMotion();
useEffect(() => {
@ -322,11 +321,10 @@ export function SourceDetailPanel({
);
});
// After final attempt, mark state as scrolled
// After final attempt, mark the cited chunk as active
scrollTimersRef.current.push(
setTimeout(
() => {
setHasScrolledToCited(true);
setActiveChunkIndex(citedChunkIndex);
},
scrollAttempts[scrollAttempts.length - 1] + 50
@ -343,7 +341,6 @@ export function SourceDetailPanel({
scrollTimersRef.current.forEach(clearTimeout);
scrollTimersRef.current = [];
hasScrolledRef.current = false;
setHasScrolledToCited(false);
setActiveChunkIndex(null);
}
return () => {