Merge pull request #1082 from SohamBhattacharjee2003/fix/hoist-regexp-in-comment-composer

fix: hoist regexp in comment composer
This commit is contained in:
Rohan Verma 2026-04-02 12:48:38 -07:00 committed by GitHub
commit 2195d894d4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -15,13 +15,17 @@ function convertDisplayToData(displayContent: string, mentions: InsertedMention[
const sortedMentions = [...mentions].sort((a, b) => b.displayName.length - a.displayName.length); const sortedMentions = [...mentions].sort((a, b) => b.displayName.length - a.displayName.length);
for (const mention of sortedMentions) { const mentionPatterns = sortedMentions.map((mention) => ({
const displayPattern = new RegExp( pattern: new RegExp(
`@${escapeRegExp(mention.displayName)}(?=\\s|$|[.,!?;:])`, `@${escapeRegExp(mention.displayName)}(?=\\s|$|[.,!?;:])`,
"g" "g"
); ),
const dataFormat = `@[${mention.id}]`; dataFormat: `@[${mention.id}]`,
result = result.replace(displayPattern, dataFormat); }));
for (const { pattern, dataFormat } of mentionPatterns) {
pattern.lastIndex = 0; // reset global regex state
result = result.replace(pattern, dataFormat);
} }
return result; return result;