From 0fb92b7c566cb48f95501dcf8f9a1ec6ea31b3d0 Mon Sep 17 00:00:00 2001
From: Anish Sarkar <104695310+AnishSarkar22@users.noreply.github.com>
Date: Mon, 6 Apr 2026 22:17:50 +0530
Subject: [PATCH] refactor: streamline file skipping logic in Dropbox indexer
 by removing redundant checks, improving code clarity

---
 .../app/tasks/connector_indexers/dropbox_indexer.py           | 4 ----
 surfsense_backend/app/utils/file_extensions.py                | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/surfsense_backend/app/tasks/connector_indexers/dropbox_indexer.py b/surfsense_backend/app/tasks/connector_indexers/dropbox_indexer.py
index ae46485cb..d116cc264 100644
--- a/surfsense_backend/app/tasks/connector_indexers/dropbox_indexer.py
+++ b/surfsense_backend/app/tasks/connector_indexers/dropbox_indexer.py
@@ -337,10 +337,6 @@ async def _index_with_delta_sync(
         if tag != "file":
             continue
 
-        if skip_item(entry):
-            skipped += 1
-            continue
-
         skip, msg = await _should_skip_file(session, entry, search_space_id)
         if skip:
             if msg and "renamed" in msg.lower():
diff --git a/surfsense_backend/app/utils/file_extensions.py b/surfsense_backend/app/utils/file_extensions.py
index 5dac10842..b0a4c808c 100644
--- a/surfsense_backend/app/utils/file_extensions.py
+++ b/surfsense_backend/app/utils/file_extensions.py
@@ -14,7 +14,7 @@ DOCUMENT_EXTENSIONS: frozenset[str] = frozenset({
     ".pdf",
     # Microsoft Office
     ".docx", ".doc", ".xlsx", ".xls", ".pptx", ".ppt",
-    # Images (raster -- OCR / vision parsing)
+    # Images (raster: OCR / vision parsing)
     ".png", ".jpg", ".jpeg", ".bmp", ".tiff", ".tif",
     # Rich text / e-book
     ".rtf", ".epub",