apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-07-02 22:01:05 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix(podcasts): guard stream against missing audio

Browse source
This commit is contained in:
CREDO23 2026-06-16 19:12:09 +02:00
parent d2558e546e
commit 0c2808640a
1 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
surfsense_backend/app/podcasts/api/routes.py
View file

@ -27,14 +27,14 @@ from app.db import (
get_async_session, get_async_session,
) )
from app.podcasts.generation.brief import propose_brief from app.podcasts.generation.brief import propose_brief
from app.podcasts.persistence import Podcast, PodcastRepository from app.podcasts.persistence import Podcast, PodcastRepository, PodcastStatus
from app.podcasts.service import ( from app.podcasts.service import (
InvalidTransitionError, InvalidTransitionError,
PodcastService, PodcastService,
PreconditionFailedError, PreconditionFailedError,
SpecConflictError, SpecConflictError,
) )
from app.podcasts.storage import open_audio_stream, purge_audio from app.podcasts.storage import audio_exists, open_audio_stream, purge_audio
from app.podcasts.tasks import draft_transcript_task from app.podcasts.tasks import draft_transcript_task
from app.podcasts.tts import get_text_to_speech from app.podcasts.tts import get_text_to_speech
from app.podcasts.voices import ( from app.podcasts.voices import (
@ -272,6 +272,11 @@ async def stream_podcast(
podcast = await _load(session, user, podcast_id, Permission.PODCASTS_READ) podcast = await _load(session, user, podcast_id, Permission.PODCASTS_READ)
if podcast.storage_key: if podcast.storage_key:
# Verify first so a missing object is a 404, not a mid-stream crash.
if not await audio_exists(podcast):
raise HTTPException(
status_code=404, detail="Podcast audio is no longer available"
)
return StreamingResponse( return StreamingResponse(
open_audio_stream(podcast), open_audio_stream(podcast),
media_type="audio/mpeg", media_type="audio/mpeg",
@ -295,7 +300,10 @@ async def stream_podcast(
}, },
) )
raise HTTPException(status_code=404, detail="Podcast audio not found") # No audio: terminal states never will have any, otherwise it's in flight.
if PodcastStatus(podcast.status).is_terminal:
raise HTTPException(status_code=404, detail="Podcast audio not found")
raise HTTPException(status_code=409, detail="Podcast audio is not ready yet")
async def _require( async def _require(