apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-05-17 18:35:19 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: guard empty update_issue call and unify delete_from_kb naming

Browse source 
- LinearConnector.update_issue: return error early when no fields are
  provided, preventing a silent no-op mutation and unnecessary KB sync
- Rename delete_from_db → delete_from_kb in delete_notion_page tool and
  its frontend component to match the more accurate Linear naming and
  keep both tool APIs consistent for the LLM
This commit is contained in:
CREDO23 2026-02-19 15:22:36 +02:00
parent 8711ac82a5
commit 090b69cf1e
3 changed files with 33 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

38
surfsense_backend/app/agents/new_chat/tools/notion/delete_page.py
View file

@ -33,7 +33,7 @@ def create_delete_notion_page_tool(
@tool
async def delete_notion_page(
page_title: str,
delete_from_db: bool = False,
delete_from_kb: bool = False,
) -> dict[str, Any]:
"""Delete (archive) a Notion page.
@ -43,8 +43,8 @@ def create_delete_notion_page_tool(
Args:
page_title: The title of the Notion page to delete.
delete_from_db: Whether to also remove the page from the knowledge base.
Default is False (in Notion).
delete_from_kb: Whether to also remove the page from the knowledge base.
Default is False.
Set to True to permanently remove from both Notion and knowledge base.
Returns:
@ -52,7 +52,7 @@ def create_delete_notion_page_tool(
- status: "success", "rejected", "not_found", or "error"
- page_id: Deleted page ID (if success)
- message: Success or error message
- deleted_from_db: Whether the page was also removed from knowledge base (if success)
- deleted_from_kb: Whether the page was also removed from knowledge base (if success)
Examples:
- "Delete the 'Meeting Notes' Notion page"
@ -60,7 +60,7 @@ def create_delete_notion_page_tool(
- "Archive the 'Draft Ideas' Notion page"
"""
logger.info(
f"delete_notion_page called: page_title='{page_title}', delete_from_db={delete_from_db}"
f"delete_notion_page called: page_title='{page_title}', delete_from_kb={delete_from_kb}"
)
if db_session is None or search_space_id is None or user_id is None:
@ -100,7 +100,7 @@ def create_delete_notion_page_tool(
document_id = context.get("document_id")
logger.info(
f"Requesting approval for deleting Notion page: '{page_title}' (page_id={page_id}, delete_from_db={delete_from_db})"
f"Requesting approval for deleting Notion page: '{page_title}' (page_id={page_id}, delete_from_kb={delete_from_kb})"
)
# Request approval before deleting
@ -112,7 +112,7 @@ def create_delete_notion_page_tool(
"params": {
"page_id": page_id,
"connector_id": connector_id_from_context,
"delete_from_db": delete_from_db,
"delete_from_kb": delete_from_kb,
},
},
"context": context,
@ -159,10 +159,10 @@ def create_delete_notion_page_tool(
final_connector_id = final_params.get(
"connector_id", connector_id_from_context
)
final_delete_from_db = final_params.get("delete_from_db", delete_from_db)
final_delete_from_kb = final_params.get("delete_from_kb", delete_from_kb)
logger.info(
f"Deleting Notion page with final params: page_id={final_page_id}, connector_id={final_connector_id}, delete_from_db={final_delete_from_db}"
f"Deleting Notion page with final params: page_id={final_page_id}, connector_id={final_connector_id}, delete_from_kb={final_delete_from_kb}"
)
from sqlalchemy.future import select
@ -211,11 +211,11 @@ def create_delete_notion_page_tool(
f"delete_page result: {result.get('status')} - {result.get('message', '')}"
)
# If deletion was successful and user wants to delete from DB
deleted_from_db = False
# If deletion was successful and user wants to delete from KB
deleted_from_kb = False
if (
result.get("status") == "success"
and final_delete_from_db
and final_delete_from_kb
and document_id
):
try:
@ -232,24 +232,24 @@ def create_delete_notion_page_tool(
if document:
await db_session.delete(document)
await db_session.commit()
deleted_from_db = True
deleted_from_kb = True
logger.info(
f"Deleted document {document_id} from knowledge base"
)
else:
logger.warning(f"Document {document_id} not found in DB")
logger.warning(f"Document {document_id} not found in KB")
except Exception as e:
logger.error(f"Failed to delete document from DB: {e}")
# Don't fail the whole operation if DB deletion fails
logger.error(f"Failed to delete document from KB: {e}")
# Don't fail the whole operation if KB deletion fails
# The page is already deleted from Notion, so inform the user
result["warning"] = (
f"Page deleted from Notion, but failed to remove from knowledge base: {e!s}"
)
# Update result with DB deletion status
# Update result with KB deletion status
if result.get("status") == "success":
result["deleted_from_db"] = deleted_from_db
if deleted_from_db:
result["deleted_from_kb"] = deleted_from_kb
if deleted_from_kb:
result["message"] = (
f"{result.get('message', '')} (also removed from knowledge base)"
)

6
surfsense_backend/app/connectors/linear_connector.py
View file

@ -675,6 +675,12 @@ class LinearConnector:
if label_ids is not None:
input_data["labelIds"] = label_ids
if not input_data:
return {
"status": "error",
"message": "No fields provided for update. Please specify at least one field to change.",
}
result = await self.execute_graphql_query(
mutation, {"id": issue_id, "input": input_data}
)

16
surfsense_web/components/tool-ui/notion/delete-notion-page.tsx
View file

@ -47,7 +47,7 @@ interface SuccessResult {
page_id: string;
title?: string;
message?: string;
deleted_from_db?: boolean;
deleted_from_kb?: boolean;
}
interface ErrorResult {
@ -129,7 +129,7 @@ function ApprovalCard({
const [decided, setDecided] = useState<"approve" | "reject" | null>(
interruptData.__decided__ ?? null
);
const [deleteFromDb, setDeleteFromDb] = useState(false);
const [deleteFromKb, setDeleteFromKb] = useState(false);
const account = interruptData.context?.account;
const currentTitle = interruptData.context?.current_title;
@ -203,8 +203,8 @@ function ApprovalCard({
<label className="flex items-start gap-2 cursor-pointer">
<input
type="checkbox"
checked={deleteFromDb}
onChange={(e) => setDeleteFromDb(e.target.checked)}
checked={deleteFromKb}
onChange={(e) => setDeleteFromKb(e.target.checked)}
className="mt-0.5"
/>
<div className="flex-1">
@ -249,7 +249,7 @@ function ApprovalCard({
args: {
page_id: interruptData.context?.page_id,
connector_id: account?.id,
delete_from_db: deleteFromDb,
delete_from_kb: deleteFromKb,
},
},
});
@ -346,7 +346,7 @@ function SuccessCard({ result }: { result: SuccessResult }) {
</p>
</div>
</div>
{(result.deleted_from_db || result.title) && (
{(result.deleted_from_kb || result.title) && (
<div className="space-y-2 px-4 py-3 text-xs">
{result.title && (
<div>
@ -354,7 +354,7 @@ function SuccessCard({ result }: { result: SuccessResult }) {
<span>{result.title}</span>
</div>
)}
{result.deleted_from_db && (
{result.deleted_from_kb && (
<div className="pt-1">
<span className="text-green-600 dark:text-green-500">
✓ Also removed from knowledge base
@ -368,7 +368,7 @@ function SuccessCard({ result }: { result: SuccessResult }) {
}
export const DeleteNotionPageToolUI = makeAssistantToolUI<
{ page_title: string; delete_from_db?: boolean },
{ page_title: string; delete_from_kb?: boolean },
DeleteNotionPageResult
>({
toolName: "delete_notion_page",