mirror of
https://github.com/MODSetter/SurfSense.git
synced 2026-05-13 17:52:38 +02:00
test(web): add Composio Drive E2E user journey
This commit is contained in:
parent
ae0caad292
commit
074b06441f
7 changed files with 275 additions and 0 deletions
56
surfsense_web/tests/connectors/composio/drive/README.md
Normal file
56
surfsense_web/tests/connectors/composio/drive/README.md
Normal file
|
|
@ -0,0 +1,56 @@
|
|||
# Composio Google Drive — E2E
|
||||
|
||||
Phase 1 Playwright coverage for the Composio Drive connector.
|
||||
|
||||
## Journey in this folder
|
||||
|
||||
| File | User expectation |
|
||||
| --- | --- |
|
||||
| `journey.spec.ts` | "I connect Google Drive, choose a file, wait for indexing, and SurfSense contains that file's content." |
|
||||
|
||||
## What "passes" actually proves
|
||||
|
||||
- The dashboard and connector dialog render for the authenticated user.
|
||||
- The Composio Drive connector fixture can complete the happy OAuth setup.
|
||||
- The selected Drive file config can be persisted.
|
||||
- Pipeline service summarizes/embeds/chunks an indexed file end-to-end.
|
||||
- Celery worker is reachable from the FastAPI process (queue + broker).
|
||||
- `Document.content` contains the Drive canary token after indexing.
|
||||
|
||||
## Edge cases tested elsewhere
|
||||
|
||||
Playwright does not own backend edge cases. They are cheaper and easier
|
||||
to localize in pytest:
|
||||
|
||||
- OAuth state freshness/tamper/malformed validation:
|
||||
`surfsense_backend/tests/unit/utils/test_oauth_security.py`
|
||||
- OAuth denied callback and duplicate/reconnection branch:
|
||||
`surfsense_backend/tests/integration/composio/test_oauth_callback.py`
|
||||
- Folder listing, selected file config persistence, and auth-expired
|
||||
classification:
|
||||
`surfsense_backend/tests/integration/composio/test_drive_folders_route.py`
|
||||
|
||||
## What "passes" does NOT prove
|
||||
|
||||
- Real Composio.dev integration (mocked).
|
||||
- Real LLM summarization quality (`FakeListChatModel`).
|
||||
- Real embedding semantics (constant 0.1 vectors).
|
||||
|
||||
These are intentional. Phase 1's deal is "the user-visible Drive
|
||||
journey crosses the connector/indexing seams". Phase 2 can add opt-in
|
||||
"live LLM" smoke tests under a separate workflow and a separate budget.
|
||||
|
||||
## Adding a fourth Composio toolkit (e.g. Slack)
|
||||
|
||||
1. Add fixture data to
|
||||
`surfsense_backend/tests/e2e/fakes/fixtures/<toolkit>_*.json`.
|
||||
2. Extend `_Tools.execute()` in
|
||||
`surfsense_backend/tests/e2e/fakes/composio_module.py` to handle the
|
||||
new toolkit's tool slugs (`SLACK_FETCH_CONVERSATIONS`, etc.).
|
||||
3. Add the toolkit to `_AuthConfigs.list()`.
|
||||
4. Drop a sibling folder `tests/connectors/composio/<toolkit>/` with
|
||||
one `journey.spec.ts` that matches the user's expectation for that
|
||||
toolkit.
|
||||
|
||||
The fixtures in `tests/fixtures/connectors/composio-drive.fixture.ts`
|
||||
are the template — copy + change `toolkit_id`.
|
||||
105
surfsense_web/tests/connectors/composio/drive/journey.spec.ts
Normal file
105
surfsense_web/tests/connectors/composio/drive/journey.spec.ts
Normal file
|
|
@ -0,0 +1,105 @@
|
|||
import { composioDriveTest as test, expect } from "../../../fixtures";
|
||||
import { listConnectors, triggerIndex, updateConnectorConfig } from "../../../helpers/api/connectors";
|
||||
import { listDocuments } from "../../../helpers/api/documents";
|
||||
import { CANARY_TOKENS, FAKE_DRIVE_FILES } from "../../../helpers/canary";
|
||||
import { openConnectorPopup } from "../../../helpers/ui/connector-popup";
|
||||
import {
|
||||
waitForDocumentByTitle,
|
||||
waitForIndexingComplete,
|
||||
} from "../../../helpers/waits/indexing";
|
||||
|
||||
/**
|
||||
* Composio Drive user journey.
|
||||
*
|
||||
* User expectation:
|
||||
* "I connect Google Drive, choose the files/folders I care about,
|
||||
* wait for indexing, and then my Drive content is available in SurfSense."
|
||||
*
|
||||
* The OAuth connection is handled by the composioDriveConnector fixture so
|
||||
* this test can focus on the user-visible expectation. The spec still touches
|
||||
* the browser (dashboard + connector dialog) and then uses API helpers for
|
||||
* selection/indexing to keep the expensive pipeline assertion deterministic.
|
||||
*
|
||||
* If this passes, the seam from Composio connection -> selection persistence ->
|
||||
* Celery indexing -> document storage is wired correctly.
|
||||
*/
|
||||
test.describe("Composio Drive journey", () => {
|
||||
test(
|
||||
"user connects Drive, selects a file, and sees it indexed with the canary token",
|
||||
async ({ page, request, apiToken, searchSpace, composioDriveConnector }) => {
|
||||
test.setTimeout(180_000); // worker cold-start + summarize + embed + chunk
|
||||
|
||||
await page.goto(`/dashboard/${searchSpace.id}/new-chat`, {
|
||||
waitUntil: "domcontentloaded",
|
||||
});
|
||||
await openConnectorPopup(page);
|
||||
await expect(
|
||||
page
|
||||
.getByRole("dialog", { name: "Manage Connectors" })
|
||||
.getByText("Search your Drive files via Composio")
|
||||
).toBeVisible();
|
||||
|
||||
await updateConnectorConfig(request, apiToken, composioDriveConnector.id, {
|
||||
...composioDriveConnector.config,
|
||||
selected_folders: [],
|
||||
selected_files: [
|
||||
{
|
||||
id: FAKE_DRIVE_FILES.canary.id,
|
||||
name: FAKE_DRIVE_FILES.canary.name,
|
||||
mimeType: FAKE_DRIVE_FILES.canary.mimeType,
|
||||
},
|
||||
],
|
||||
indexing_options: {
|
||||
max_files_per_folder: 10,
|
||||
incremental_sync: false,
|
||||
include_subfolders: false,
|
||||
},
|
||||
});
|
||||
|
||||
await triggerIndex(request, apiToken, composioDriveConnector.id, searchSpace.id, {
|
||||
files: [
|
||||
{
|
||||
id: FAKE_DRIVE_FILES.canary.id,
|
||||
name: FAKE_DRIVE_FILES.canary.name,
|
||||
mimeType: FAKE_DRIVE_FILES.canary.mimeType,
|
||||
},
|
||||
],
|
||||
indexing_options: {
|
||||
max_files_per_folder: 10,
|
||||
incremental_sync: false,
|
||||
include_subfolders: false,
|
||||
},
|
||||
});
|
||||
|
||||
await waitForIndexingComplete(request, apiToken, composioDriveConnector.id, searchSpace.id, {
|
||||
timeoutMs: 150_000,
|
||||
intervalMs: 1_500,
|
||||
minDocuments: 1,
|
||||
});
|
||||
|
||||
await waitForDocumentByTitle(
|
||||
request,
|
||||
apiToken,
|
||||
searchSpace.id,
|
||||
FAKE_DRIVE_FILES.canary.name,
|
||||
{ timeoutMs: 30_000 }
|
||||
);
|
||||
|
||||
const docs = await listDocuments(request, apiToken, searchSpace.id);
|
||||
const canaryDoc = docs.find((d) => d.title === FAKE_DRIVE_FILES.canary.name);
|
||||
|
||||
expect(canaryDoc, "canary document must exist after indexing").toBeDefined();
|
||||
|
||||
const content = canaryDoc!.content ?? "";
|
||||
expect(
|
||||
content,
|
||||
`canary token ${CANARY_TOKENS.driveCanaryFile} should appear in Document.content; ` +
|
||||
`got first 200 chars: ${content.slice(0, 200)}`
|
||||
).toContain(CANARY_TOKENS.driveCanaryFile);
|
||||
|
||||
const refreshedConnectors = await listConnectors(request, apiToken, searchSpace.id);
|
||||
const refreshed = refreshedConnectors.find((c) => c.id === composioDriveConnector.id);
|
||||
expect(refreshed?.last_indexed_at).not.toBeNull();
|
||||
}
|
||||
);
|
||||
});
|
||||
Loading…
Add table
Add a link
Reference in a new issue