apunkt/SurfSense
1
0
Fork 0
mirror of https://github.com/MODSetter/SurfSense.git synced 2026-06-06 20:15:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

fix: add cancelAnimationFrame cleanup in animated-tabs useEffect

Browse source 
Fixes issue #1093 - requestAnimationFrame was called without cleanup,
causing potential memory leaks and errors when component unmounts before
the frame fires.

- Store frame ID returned by requestAnimationFrame
- Return cleanup function that calls cancelAnimationFrame
This commit is contained in:
universe7creator 2026-04-04 10:56:19 +03:00
parent c2bd2bc935
commit 0197f027f8
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
surfsense_web/components/ui/animated-tabs.tsx
View file

@ -306,7 +306,8 @@ const TabsList = forwardRef<
}, [updateActiveIndicator]); }, [updateActiveIndicator]);
useEffect(() => { useEffect(() => {
requestAnimationFrame(updateActiveIndicator); const frameId = requestAnimationFrame(updateActiveIndicator);
return () => cancelAnimationFrame(frameId);
}, [updateActiveIndicator]); }, [updateActiveIndicator]);
const scrollTabToCenter = useCallback((index: number) => { const scrollTabToCenter = useCallback((index: number) => {