mirror of
https://github.com/VectifyAI/PageIndex.git
synced 2026-07-15 21:11:05 +02:00
Verified 12 findings from an xhigh-effort review of the prior review-fix
batch; all confirmed real. Most trace back to one root cause: the
build_index() text-stripping fix (8f536cb) correctly stopped Markdown from
leaking full text by default, but broke every path that assumed text could
be re-read later.
Correctness:
- LocalBackend._fill_node_text (get_document(include_text=True)) only handled
PDF's start_index/end_index convention; Markdown nodes use line_num and got
silently empty text. Now handles both.
- get_page_content's Markdown fallback (triggered when a StorageEngine
legitimately returns None from get_pages()) read from the now-text-stripped
structure. It now re-derives from the source file, mirroring the PDF
fallback, so it no longer depends on structure text at all.
- add_document's PDF-only text-stripping branch (with the stale "markdown
needs text in structure for fallback retrieval" comment) is now dead/wrong
since build_index() already applies if_add_node_text uniformly — removed.
- _validate_llm_provider's keyless-provider allowlist was missing several
local LiteLLM providers (xinference, llamafile, triton, oobabooga,
openai_like, docker_model_runner, custom, custom_openai, petals) that need
no API key just like ollama/lm_studio; expanded.
- The three agent-tool closures (get_document, get_document_structure,
get_page_content) had three different not-found patterns; two bypassed the
backend's DocumentNotFoundError entirely. Extracted LocalBackend.
_require_document as the single existence check every method/tool now uses.
- examples/agentic_vectorless_rag_demo.py's hand-rolled Agent() didn't apply
the litellm/ prefix normalization the SDK does internally, so its own
documented "any LiteLLM provider" claim broke for non-openai models.
- cloud delete_collection's cache eviction removed the "folders unavailable"
None sentinel too, forcing a wasted re-fetch; now only pops on a real id.
Cleanup / altitude:
- build_index() skips the remove_structure_text walk entirely when text was
never added (content_based + if_add_node_summary=False + if_add_node_text=
False) instead of a guaranteed no-op tree walk.
- page_index()'s locals()-capture-as-kwargs (fragile by construction) replaced
with an explicit dict of the named parameters.
- run_pageindex.py's _cli_bool and the page_index_md.py legacy shim's
_coerce_bool were duplicate, diverging implementations; both now bind
directly to the canonical pageindex.index.page_index_md._coerce_bool.
- retrieve.py's _get_md_page_content delegated its own traversal instead of
calling the canonical get_md_page_content; now a one-line delegation.
- FileTypeError's docstring now calls out the except-ordering gotcha from
also subclassing ValueError.
17 new regression tests (tests/test_review_fixes_2.py) plus 2 updated in
tests/test_legacy_shims.py for the simplified md_to_tree shim. Full suite:
210 passed, 2 skipped.
Claude-Session: https://claude.ai/code/session_01Kx5DgKbhK1N8autqXH8SmS
120 lines
4.7 KiB
Python
120 lines
4.7 KiB
Python
import json
|
|
import PyPDF2
|
|
|
|
try:
|
|
from .index.utils import get_number_of_pages, remove_fields, get_md_page_content
|
|
except ImportError:
|
|
from index.utils import get_number_of_pages, remove_fields, get_md_page_content
|
|
|
|
|
|
# ── Helpers ──────────────────────────────────────────────────────────────────
|
|
|
|
def _parse_pages(pages: str) -> list[int]:
|
|
"""Parse a pages string like '5-7', '3,8', or '12' into a sorted list of ints."""
|
|
result = []
|
|
for part in pages.split(','):
|
|
part = part.strip()
|
|
if '-' in part:
|
|
start, end = int(part.split('-', 1)[0].strip()), int(part.split('-', 1)[1].strip())
|
|
if start > end:
|
|
raise ValueError(f"Invalid range '{part}': start must be <= end")
|
|
result.extend(range(start, end + 1))
|
|
else:
|
|
result.append(int(part))
|
|
return sorted(set(result))
|
|
|
|
|
|
def _count_pages(doc_info: dict) -> int:
|
|
"""Return total page count for a PDF document."""
|
|
if doc_info.get('page_count'):
|
|
return doc_info['page_count']
|
|
if doc_info.get('pages'):
|
|
return len(doc_info['pages'])
|
|
return get_number_of_pages(doc_info['path'])
|
|
|
|
|
|
def _get_pdf_page_content(doc_info: dict, page_nums: list[int]) -> list[dict]:
|
|
"""Extract text for specific PDF pages (1-indexed). Prefer cached pages, fallback to PDF."""
|
|
cached_pages = doc_info.get('pages')
|
|
if cached_pages:
|
|
page_map = {p['page']: p['content'] for p in cached_pages}
|
|
return [
|
|
{'page': p, 'content': page_map[p]}
|
|
for p in page_nums if p in page_map
|
|
]
|
|
path = doc_info['path']
|
|
with open(path, 'rb') as f:
|
|
pdf_reader = PyPDF2.PdfReader(f)
|
|
total = len(pdf_reader.pages)
|
|
valid_pages = [p for p in page_nums if 1 <= p <= total]
|
|
return [
|
|
{'page': p, 'content': pdf_reader.pages[p - 1].extract_text() or ''}
|
|
for p in valid_pages
|
|
]
|
|
|
|
|
|
def _get_md_page_content(doc_info: dict, page_nums: list[int]) -> list[dict]:
|
|
"""For Markdown documents, 'pages' are line numbers. Delegates to the
|
|
canonical implementation so the two never drift again."""
|
|
return get_md_page_content(doc_info.get('structure', []), page_nums)
|
|
|
|
|
|
# ── Tool functions ────────────────────────────────────────────────────────────
|
|
|
|
def get_document(documents: dict, doc_id: str) -> str:
|
|
"""Return JSON with document metadata: doc_id, doc_name, doc_description, type, status, page_count (PDF) or line_count (Markdown)."""
|
|
doc_info = documents.get(doc_id)
|
|
if not doc_info:
|
|
return json.dumps({'error': f'Document {doc_id} not found'})
|
|
result = {
|
|
'doc_id': doc_id,
|
|
'doc_name': doc_info.get('doc_name', ''),
|
|
'doc_description': doc_info.get('doc_description', ''),
|
|
'type': doc_info.get('type', ''),
|
|
'status': 'completed',
|
|
}
|
|
if doc_info.get('type') == 'pdf':
|
|
result['page_count'] = _count_pages(doc_info)
|
|
else:
|
|
result['line_count'] = doc_info.get('line_count', 0)
|
|
return json.dumps(result)
|
|
|
|
|
|
def get_document_structure(documents: dict, doc_id: str) -> str:
|
|
"""Return tree structure JSON with text fields removed (saves tokens)."""
|
|
doc_info = documents.get(doc_id)
|
|
if not doc_info:
|
|
return json.dumps({'error': f'Document {doc_id} not found'})
|
|
structure = doc_info.get('structure', [])
|
|
structure_no_text = remove_fields(structure, fields=['text'])
|
|
return json.dumps(structure_no_text, ensure_ascii=False)
|
|
|
|
|
|
def get_page_content(documents: dict, doc_id: str, pages: str) -> str:
|
|
"""
|
|
Retrieve page content for a document.
|
|
|
|
pages format: '5-7', '3,8', or '12'
|
|
For PDF: pages are physical page numbers (1-indexed).
|
|
For Markdown: pages are line numbers corresponding to node headers.
|
|
|
|
Returns JSON list of {'page': int, 'content': str}.
|
|
"""
|
|
doc_info = documents.get(doc_id)
|
|
if not doc_info:
|
|
return json.dumps({'error': f'Document {doc_id} not found'})
|
|
|
|
try:
|
|
page_nums = _parse_pages(pages)
|
|
except (ValueError, AttributeError) as e:
|
|
return json.dumps({'error': f'Invalid pages format: {pages!r}. Use "5-7", "3,8", or "12". Error: {e}'})
|
|
|
|
try:
|
|
if doc_info.get('type') == 'pdf':
|
|
content = _get_pdf_page_content(doc_info, page_nums)
|
|
else:
|
|
content = _get_md_page_content(doc_info, page_nums)
|
|
except Exception as e:
|
|
return json.dumps({'error': f'Failed to read page content: {e}'})
|
|
|
|
return json.dumps(content, ensure_ascii=False)
|