mirror of
https://github.com/VectifyAI/PageIndex.git
synced 2026-07-15 21:11:05 +02:00
4e6a13576d
Addresses items 9-13 and a/b/c/f from the max-effort review of PR #272. - pdf.py: image colorspace check was `pix.n > 4`, which treats CMYK-without- alpha (n==4, same as RGBA) as not needing RGB conversion; pix.save() as .png then raises "unsupported colorspace", silently dropped by the surrounding except. Fixed to `pix.n - pix.alpha >= 4` (correctly converts CMYK, leaves RGBA untouched). - pipeline.py: detect_strategy([]) (an empty/whitespace-only source file) returned "content_based", routing into the PDF-oriented TOC-detection pipeline -- wasting a real LLM call before raising IndexingError. Empty node lists now route to level_based, whose build_tree_from_levels([]) returns an empty structure instantly with zero LLM calls. - page_index.py (shim): pageindex/__init__.py binds the canonical `page_index` function as the package attribute, but this file is ALSO a real submodule of the same name -- importing it anywhere (import machinery, unconditional) overwrites that attribute with the module object, breaking `from pageindex import page_index; page_index(x)` for the rest of the process. Made the shim module itself callable (delegates to the real function via a ModuleType subclass), so whichever object ends up in that slot is callable regardless of import order. - storage/sqlite.py: create_collection let a raw sqlite3.IntegrityError escape on a duplicate name (new CollectionAlreadyExistsError); the collections table's CHECK constraint only validated the name's first character (GLOB '*' is a wildcard, not a regex quantifier over the preceding class) -- fixed to validate the whole string, and SQLiteStorage now also validates in Python (it's a public StorageEngine usable directly, bypassing LocalBackend's own check). - tests/test_review_fixes_2.py: two tests used a ContentNode with no `level` set, so build_index took the content_based path and made real (retried, slow, and -- with a valid key -- billable) LLM calls instead of testing the text-stripping logic they claimed to. Mocked out _content_based_pipeline. - retrieve.py: _parse_pages/_get_pdf_page_content were independent copies of the canonical parse_pages/get_pdf_page_content that had already drifted (missing the p>=1 filter and 1000-page DoS cap) -- delegate to canonical now, so the legacy pageindex.get_page_content path can't silently regress again. - parser/markdown.py: a leading UTF-8 BOM broke first-header detection (not whitespace, .strip() doesn't remove it) -- decode utf-8-sig. Only backtick fences were recognized as code blocks, so a '#'-prefixed line inside a ~~~-fenced block (valid CommonMark) was misparsed as a heading -- recognize both fence styles. - run_pageindex.py: --if-thinning wasn't migrated to the bare-flag + legacy-yes/no convention the other four --if-add-* flags got; bare usage raised an argparse error and it never went through the shared coercion. - types.py: DocumentDetail's `structure` field was inside the class's total=False body, so TypedDict rules made it optional even though every backend always populates it. Split into a required base class. Adds regression tests for all of the above. Full suite: 244 passed, 2 skipped (one pre-existing, unrelated flaky cloud-streaming test). Claude-Session: https://claude.ai/code/session_01Kx5DgKbhK1N8autqXH8SmS
57 lines
1.6 KiB
Python
57 lines
1.6 KiB
Python
class PageIndexError(Exception):
|
|
"""Base exception for all PageIndex SDK errors."""
|
|
pass
|
|
|
|
|
|
class CollectionNotFoundError(PageIndexError):
|
|
"""Collection does not exist."""
|
|
pass
|
|
|
|
|
|
class CollectionAlreadyExistsError(PageIndexError):
|
|
"""Collection already exists (create_collection, not get_or_create)."""
|
|
pass
|
|
|
|
|
|
class DocumentNotFoundError(PageIndexError):
|
|
"""Document ID not found."""
|
|
pass
|
|
|
|
|
|
class IndexingError(PageIndexError):
|
|
"""Indexing pipeline failure."""
|
|
pass
|
|
|
|
|
|
class PageIndexAPIError(PageIndexError):
|
|
"""PageIndex cloud API returned an error.
|
|
|
|
Kept for compatibility with the pageindex 0.2.x cloud SDK.
|
|
"""
|
|
pass
|
|
|
|
|
|
class CloudAPIError(PageIndexAPIError):
|
|
"""Cloud API returned error.
|
|
|
|
``status_code`` carries the HTTP status when the error came from an HTTP
|
|
response (None for transport-level failures), so callers can branch on it
|
|
instead of parsing the message.
|
|
"""
|
|
|
|
def __init__(self, message: str, status_code: int | None = None):
|
|
super().__init__(message)
|
|
self.status_code = status_code
|
|
|
|
|
|
class FileTypeError(PageIndexError, ValueError):
|
|
"""Unsupported file type.
|
|
|
|
Also subclasses ValueError so pre-SDK ``except ValueError`` around indexing
|
|
(0.2.x raised ValueError for an unsupported file format) still catches it.
|
|
Note: because of this, an ``except ValueError`` clause ahead of an
|
|
``except FileTypeError`` clause in the same try block will catch it first —
|
|
if you need FileTypeError-specific handling, put that except before (or
|
|
instead of) a bare ValueError one.
|
|
"""
|
|
pass
|