mirror of
https://github.com/VectifyAI/PageIndex.git
synced 2026-07-15 21:11:05 +02:00
Verified 12 findings from an xhigh-effort review of the prior review-fix
batch; all confirmed real. Most trace back to one root cause: the
build_index() text-stripping fix (8f536cb) correctly stopped Markdown from
leaking full text by default, but broke every path that assumed text could
be re-read later.
Correctness:
- LocalBackend._fill_node_text (get_document(include_text=True)) only handled
PDF's start_index/end_index convention; Markdown nodes use line_num and got
silently empty text. Now handles both.
- get_page_content's Markdown fallback (triggered when a StorageEngine
legitimately returns None from get_pages()) read from the now-text-stripped
structure. It now re-derives from the source file, mirroring the PDF
fallback, so it no longer depends on structure text at all.
- add_document's PDF-only text-stripping branch (with the stale "markdown
needs text in structure for fallback retrieval" comment) is now dead/wrong
since build_index() already applies if_add_node_text uniformly — removed.
- _validate_llm_provider's keyless-provider allowlist was missing several
local LiteLLM providers (xinference, llamafile, triton, oobabooga,
openai_like, docker_model_runner, custom, custom_openai, petals) that need
no API key just like ollama/lm_studio; expanded.
- The three agent-tool closures (get_document, get_document_structure,
get_page_content) had three different not-found patterns; two bypassed the
backend's DocumentNotFoundError entirely. Extracted LocalBackend.
_require_document as the single existence check every method/tool now uses.
- examples/agentic_vectorless_rag_demo.py's hand-rolled Agent() didn't apply
the litellm/ prefix normalization the SDK does internally, so its own
documented "any LiteLLM provider" claim broke for non-openai models.
- cloud delete_collection's cache eviction removed the "folders unavailable"
None sentinel too, forcing a wasted re-fetch; now only pops on a real id.
Cleanup / altitude:
- build_index() skips the remove_structure_text walk entirely when text was
never added (content_based + if_add_node_summary=False + if_add_node_text=
False) instead of a guaranteed no-op tree walk.
- page_index()'s locals()-capture-as-kwargs (fragile by construction) replaced
with an explicit dict of the named parameters.
- run_pageindex.py's _cli_bool and the page_index_md.py legacy shim's
_coerce_bool were duplicate, diverging implementations; both now bind
directly to the canonical pageindex.index.page_index_md._coerce_bool.
- retrieve.py's _get_md_page_content delegated its own traversal instead of
calling the canonical get_md_page_content; now a one-line delegation.
- FileTypeError's docstring now calls out the except-ordering gotcha from
also subclassing ValueError.
17 new regression tests (tests/test_review_fixes_2.py) plus 2 updated in
tests/test_legacy_shims.py for the simplified md_to_tree shim. Full suite:
210 passed, 2 skipped.
Claude-Session: https://claude.ai/code/session_01Kx5DgKbhK1N8autqXH8SmS
125 lines
5.9 KiB
Python
125 lines
5.9 KiB
Python
import argparse
|
|
import os
|
|
import json
|
|
from pageindex.index.page_index import *
|
|
# Reuse the canonical yes/no coercion (as _cli_bool) instead of a second copy —
|
|
# a bare ``--flag`` (no value) resolves to True via argparse's ``const``; an
|
|
# explicit value keeps the legacy yes/no style working, so ``--flag no`` turns
|
|
# it off. argparse only ever passes a str here (const/default bypass type=).
|
|
from pageindex.index.page_index_md import md_to_tree, _coerce_bool as _cli_bool
|
|
from pageindex.config import IndexConfig
|
|
|
|
|
|
if __name__ == "__main__":
|
|
# Set up argument parser
|
|
parser = argparse.ArgumentParser(description='Process PDF or Markdown document and generate structure')
|
|
parser.add_argument('--pdf_path', type=str, help='Path to the PDF file')
|
|
parser.add_argument('--md_path', type=str, help='Path to the Markdown file')
|
|
|
|
parser.add_argument('--model', type=str, default=None, help='Model to use')
|
|
|
|
parser.add_argument('--toc-check-pages', type=int, default=None,
|
|
help='Number of pages to check for table of contents (PDF only)')
|
|
parser.add_argument('--max-pages-per-node', type=int, default=None,
|
|
help='Maximum number of pages per node (PDF only)')
|
|
parser.add_argument('--max-tokens-per-node', type=int, default=None,
|
|
help='Maximum number of tokens per node (PDF only)')
|
|
|
|
# Bare flag (e.g. --if-add-node-id) turns the option on; an explicit value
|
|
# keeps the legacy yes/no style, so --if-add-node-id no turns it off.
|
|
parser.add_argument('--if-add-node-id', nargs='?', const=True, type=_cli_bool, default=None,
|
|
help='Add node IDs (on by default). Bare flag or yes/no, e.g. --if-add-node-id no')
|
|
parser.add_argument('--if-add-node-summary', nargs='?', const=True, type=_cli_bool, default=None,
|
|
help='Add node summaries (on by default). Bare flag or yes/no')
|
|
parser.add_argument('--if-add-doc-description', nargs='?', const=True, type=_cli_bool, default=None,
|
|
help='Add a document description (on by default). Bare flag or yes/no')
|
|
parser.add_argument('--if-add-node-text', nargs='?', const=True, type=_cli_bool, default=None,
|
|
help='Add raw text to nodes (off by default). Bare flag or yes/no')
|
|
|
|
# Markdown specific arguments
|
|
parser.add_argument('--if-thinning', type=str, default='no',
|
|
help='Whether to apply tree thinning for markdown (markdown only)')
|
|
parser.add_argument('--thinning-threshold', type=int, default=5000,
|
|
help='Minimum token threshold for thinning (markdown only)')
|
|
parser.add_argument('--summary-token-threshold', type=int, default=200,
|
|
help='Token threshold for generating summaries (markdown only)')
|
|
args = parser.parse_args()
|
|
|
|
# Validate that exactly one file type is specified
|
|
if not args.pdf_path and not args.md_path:
|
|
raise ValueError("Either --pdf_path or --md_path must be specified")
|
|
if args.pdf_path and args.md_path:
|
|
raise ValueError("Only one of --pdf_path or --md_path can be specified")
|
|
|
|
# Build IndexConfig from CLI args (None values use defaults)
|
|
config_overrides = {
|
|
k: v for k, v in {
|
|
"model": args.model,
|
|
"toc_check_page_num": args.toc_check_pages,
|
|
"max_page_num_each_node": args.max_pages_per_node,
|
|
"max_token_num_each_node": args.max_tokens_per_node,
|
|
"if_add_node_id": args.if_add_node_id,
|
|
"if_add_node_summary": args.if_add_node_summary,
|
|
"if_add_doc_description": args.if_add_doc_description,
|
|
"if_add_node_text": args.if_add_node_text,
|
|
}.items() if v is not None
|
|
}
|
|
opt = IndexConfig(**config_overrides)
|
|
|
|
if args.pdf_path:
|
|
# Validate PDF file
|
|
if not args.pdf_path.lower().endswith('.pdf'):
|
|
raise ValueError("PDF file must have .pdf extension")
|
|
if not os.path.isfile(args.pdf_path):
|
|
raise ValueError(f"PDF file not found: {args.pdf_path}")
|
|
|
|
# Process the PDF
|
|
toc_with_page_number = page_index_main(args.pdf_path, opt)
|
|
print('Parsing done, saving to file...')
|
|
|
|
# Save results
|
|
pdf_name = os.path.splitext(os.path.basename(args.pdf_path))[0]
|
|
output_dir = './results'
|
|
output_file = f'{output_dir}/{pdf_name}_structure.json'
|
|
os.makedirs(output_dir, exist_ok=True)
|
|
|
|
with open(output_file, 'w', encoding='utf-8') as f:
|
|
json.dump(toc_with_page_number, f, indent=2)
|
|
|
|
print(f'Tree structure saved to: {output_file}')
|
|
|
|
elif args.md_path:
|
|
# Validate Markdown file
|
|
if not args.md_path.lower().endswith(('.md', '.markdown')):
|
|
raise ValueError("Markdown file must have .md or .markdown extension")
|
|
if not os.path.isfile(args.md_path):
|
|
raise ValueError(f"Markdown file not found: {args.md_path}")
|
|
|
|
# Process markdown file
|
|
print('Processing markdown file...')
|
|
import asyncio
|
|
|
|
toc_with_page_number = asyncio.run(md_to_tree(
|
|
md_path=args.md_path,
|
|
if_thinning=args.if_thinning.lower() == 'yes',
|
|
min_token_threshold=args.thinning_threshold,
|
|
if_add_node_summary=opt.if_add_node_summary,
|
|
summary_token_threshold=args.summary_token_threshold,
|
|
model=opt.model,
|
|
if_add_doc_description=opt.if_add_doc_description,
|
|
if_add_node_text=opt.if_add_node_text,
|
|
if_add_node_id=opt.if_add_node_id
|
|
))
|
|
|
|
print('Parsing done, saving to file...')
|
|
|
|
# Save results
|
|
md_name = os.path.splitext(os.path.basename(args.md_path))[0]
|
|
output_dir = './results'
|
|
output_file = f'{output_dir}/{md_name}_structure.json'
|
|
os.makedirs(output_dir, exist_ok=True)
|
|
|
|
with open(output_file, 'w', encoding='utf-8') as f:
|
|
json.dump(toc_with_page_number, f, indent=2, ensure_ascii=False)
|
|
|
|
print(f'Tree structure saved to: {output_file}')
|