PageIndex/tests/test_pipeline.py

178 lines
7 KiB
Python
Raw Normal View History

# tests/sdk/test_pipeline.py
import asyncio
from unittest.mock import patch, AsyncMock
from pageindex.parser.protocol import ContentNode, ParsedDocument
from pageindex.index.pipeline import (
detect_strategy, build_tree_from_levels, build_index,
_content_based_pipeline, _NullLogger,
)
def test_detect_strategy_with_level():
nodes = [
ContentNode(content="# Intro", tokens=10, title="Intro", index=1, level=1),
ContentNode(content="## Details", tokens=10, title="Details", index=5, level=2),
]
assert detect_strategy(nodes) == "level_based"
def test_detect_strategy_without_level():
nodes = [
ContentNode(content="Page 1 text", tokens=100, index=1),
ContentNode(content="Page 2 text", tokens=100, index=2),
]
assert detect_strategy(nodes) == "content_based"
def test_build_tree_from_levels():
nodes = [
ContentNode(content="ch1 text", tokens=10, title="Chapter 1", index=1, level=1),
ContentNode(content="s1.1 text", tokens=10, title="Section 1.1", index=5, level=2),
ContentNode(content="s1.2 text", tokens=10, title="Section 1.2", index=10, level=2),
ContentNode(content="ch2 text", tokens=10, title="Chapter 2", index=20, level=1),
]
tree = build_tree_from_levels(nodes)
assert len(tree) == 2 # 2 root nodes (chapters)
assert tree[0]["title"] == "Chapter 1"
assert len(tree[0]["nodes"]) == 2 # 2 sections under chapter 1
assert tree[0]["nodes"][0]["title"] == "Section 1.1"
assert tree[0]["nodes"][1]["title"] == "Section 1.2"
assert tree[1]["title"] == "Chapter 2"
assert len(tree[1]["nodes"]) == 0
def test_build_tree_from_levels_single_level():
nodes = [
ContentNode(content="a", tokens=5, title="A", index=1, level=1),
ContentNode(content="b", tokens=5, title="B", index=2, level=1),
]
tree = build_tree_from_levels(nodes)
assert len(tree) == 2
assert tree[0]["title"] == "A"
assert tree[1]["title"] == "B"
def test_build_tree_from_levels_deep_nesting():
nodes = [
ContentNode(content="h1", tokens=5, title="H1", index=1, level=1),
ContentNode(content="h2", tokens=5, title="H2", index=2, level=2),
ContentNode(content="h3", tokens=5, title="H3", index=3, level=3),
]
tree = build_tree_from_levels(nodes)
assert len(tree) == 1
assert tree[0]["title"] == "H1"
assert len(tree[0]["nodes"]) == 1
assert tree[0]["nodes"][0]["title"] == "H2"
assert len(tree[0]["nodes"][0]["nodes"]) == 1
assert tree[0]["nodes"][0]["nodes"][0]["title"] == "H3"
def test_content_based_pipeline_does_not_raise():
"""_content_based_pipeline should delegate to tree_parser, not raise NotImplementedError."""
fake_tree = [{"title": "Intro", "start_index": 1, "end_index": 2, "nodes": []}]
async def fake_tree_parser(page_list, opt, doc=None, logger=None):
return fake_tree
page_list = [("Page 1 text", 50), ("Page 2 text", 60)]
from types import SimpleNamespace
opt = SimpleNamespace(model="test-model")
with patch("pageindex.index.page_index.tree_parser", new=fake_tree_parser):
result = asyncio.run(_content_based_pipeline(page_list, opt))
assert result == fake_tree
def test_null_logger_methods():
"""NullLogger should have info/error/debug and not raise."""
logger = _NullLogger()
logger.info("test message")
logger.error("test error")
logger.debug("test debug")
logger.info({"key": "value"})
fix(index): bound LLM concurrency at the leaf, not per gather call The previous approach (bounded_gather building a fresh semaphore per call) did NOT compose: the indexing call graph nests gathers (tree_parser -> process_large_node_recursively -> recurse, plus each node's check_title gather), and each level got its own independent cap. Peak in-flight LLM calls grew ~N^depth, so a deep/wide document still exhausted file descriptors (Errno 24) — the exact failure the cap was meant to prevent — while the flat summary phase was over-serialized. Naively sharing one semaphore across gather levels would instead deadlock (a parent holds a slot while awaiting children that need slots). Move the throttle to the single chokepoint every LLM call funnels through, llm_acompletion: one shared semaphore per event loop, acquired only around the litellm.acompletion network call. This gives a true global cap that composes across any nesting and can't deadlock (a parent awaiting children holds no slot). bounded_gather is gone; the call sites revert to plain asyncio.gather. Also: - Reject bool in max_concurrency validation (bool is an int subclass, so set_max_concurrency(True) / IndexConfig(max_concurrency=True) previously became Semaphore(1) and silently serialized). Shared _validate_max_concurrency + a pydantic field_validator. - Guard check_title_appearance_in_start_concurrent against an out-of-range or 0 physical_index (LLM can emit one): it was dereferenced during task construction, outside the gather's return_exceptions protection, aborting the whole build; 0 silently wrapped to the last page. Now marked 'no'. - Propagate contextvars into agent.py's worker-thread run (mirrors pipeline._run_async) so ContextVar settings stay consistent. - Tests rewritten to cover the nested case the old flat tests missed, the leaf-level throttle in llm_acompletion, bool rejection, and the out-of-range physical_index guard. Claude-Session: https://claude.ai/code/session_01Kx5DgKbhK1N8autqXH8SmS
2026-07-08 11:26:36 +08:00
def _structure_has_text(nodes) -> bool:
for n in nodes:
if "text" in n:
return True
if n.get("nodes") and _structure_has_text(n["nodes"]):
return True
return False
def test_level_based_strips_text_by_default():
"""Markdown (level_based) must honor if_add_node_text=False — build_tree_from_
levels seeds 'text', and it used to leak into the output/storage."""
from pageindex.config import IndexConfig
nodes = [
ContentNode(content="# Intro\nbody one", tokens=5, title="Intro", index=1, level=1),
ContentNode(content="## Sub\nbody two", tokens=5, title="Sub", index=2, level=2),
]
parsed = ParsedDocument(doc_name="d", nodes=nodes)
# No summary/description -> no LLM calls.
opt = IndexConfig(if_add_node_summary=False, if_add_doc_description=False,
if_add_node_text=False)
result = build_index(parsed, opt=opt)
assert not _structure_has_text(result["structure"])
def test_level_based_keeps_text_when_requested():
from pageindex.config import IndexConfig
nodes = [ContentNode(content="# Intro\nbody", tokens=5, title="Intro", index=1, level=1)]
parsed = ParsedDocument(doc_name="d", nodes=nodes)
opt = IndexConfig(if_add_node_summary=False, if_add_doc_description=False,
if_add_node_text=True)
result = build_index(parsed, opt=opt)
assert _structure_has_text(result["structure"])
fix: prompt-injection delimiter escape, legacy config coercion, gather resilience, true cross-thread concurrency bound Addresses items 4-8 from the max-effort review of PR #272 (VectifyAI/PageIndex#272). - agent.py: wrap_with_doc_context() strips '<'/'>' from doc_name/doc_description (untrusted: unsanitized filename / LLM-generated from document content) before inserting them into the <docs>...</docs> block, so embedded content can never form a literal </docs> that closes the delimiter early and escapes the untrusted-data boundary SCOPED_SYSTEM_PROMPT relies on. Deterministic per-field transform, doesn't touch the (cacheable) static system prompt. - ConfigLoader.load() (legacy 0.2.x compat) now routes merged overrides through IndexConfig before returning, so a legacy 'no' string gets pydantic's bool coercion instead of surviving as a truthy non-empty string — page_index_main's bare `if opt.if_add_node_summary:` checks (changed from `== 'yes'` elsewhere in this PR) were silently inverting caller intent and firing unwanted billed LLM calls. - verify_toc, process_large_node_recursively, tree_parser, generate_summaries_for_structure, generate_summaries_for_structure_md: added return_exceptions=True to their asyncio.gather calls (llm_completion/ llm_acompletion raise RuntimeError on retry exhaustion, added earlier in this PR), each with a degrade path matching the pattern already used by sibling hardened gathers in the same files. One transient LLM failure no longer aborts the whole document's indexing. - _llm_semaphore is now a true process-wide ceiling (threading.Semaphore, shared across every thread/event loop) instead of one asyncio.Semaphore per event loop -- concurrently indexing N documents on N threads no longer multiplies the effective cap by N. A max_concurrency_scope() override is layered as a second, nested, per-loop restriction that can only tighten the effective cap within the ceiling, never widen past it. - set_llm_params() mutated a bare process-wide dict with no per-call isolation, unlike max_concurrency which already had ContextVar scoping. Added llm_params_scope() (mirrors max_concurrency_scope) + IndexConfig.llm_params, wired into build_index() the same way max_concurrency already was, so concurrent indexing jobs with different llm kwargs don't leak into each other. Adds regression tests for all five. Full suite: 221 passed, 2 skipped (one pre-existing, unrelated flaky cloud-streaming test intermittently fails on rerun; confirmed independent of this change). Claude-Session: https://claude.ai/code/session_01Kx5DgKbhK1N8autqXH8SmS
2026-07-09 11:15:12 +08:00
def test_build_index_scopes_llm_params_to_the_call(monkeypatch):
"""IndexConfig(llm_params=...) must reach get_llm_params() for the duration
of this build_index() call only, and not leak into the process default."""
from pageindex.config import IndexConfig, get_llm_params, set_llm_params
set_llm_params(temperature=0)
seen = {}
async def fake_generate_summaries(structure, model=None):
seen["llm_params"] = get_llm_params()
monkeypatch.setattr(
"pageindex.index.utils.generate_summaries_for_structure",
fake_generate_summaries,
)
# level_based (Markdown) strategy avoids the content_based path's own real
# LLM-driven TOC detection, so this stays a fast, network-free unit test.
nodes = [ContentNode(content="# Intro\nbody", tokens=5, title="Intro", index=1, level=1)]
parsed = ParsedDocument(doc_name="d", nodes=nodes)
opt = IndexConfig(if_add_node_summary=True, if_add_doc_description=False,
llm_params={"temperature": 1})
build_index(parsed, opt=opt)
assert seen["llm_params"]["temperature"] == 1 # scoped override was in effect
assert get_llm_params()["temperature"] == 0 # process default untouched afterward
fix(index): bound LLM concurrency at the leaf, not per gather call The previous approach (bounded_gather building a fresh semaphore per call) did NOT compose: the indexing call graph nests gathers (tree_parser -> process_large_node_recursively -> recurse, plus each node's check_title gather), and each level got its own independent cap. Peak in-flight LLM calls grew ~N^depth, so a deep/wide document still exhausted file descriptors (Errno 24) — the exact failure the cap was meant to prevent — while the flat summary phase was over-serialized. Naively sharing one semaphore across gather levels would instead deadlock (a parent holds a slot while awaiting children that need slots). Move the throttle to the single chokepoint every LLM call funnels through, llm_acompletion: one shared semaphore per event loop, acquired only around the litellm.acompletion network call. This gives a true global cap that composes across any nesting and can't deadlock (a parent awaiting children holds no slot). bounded_gather is gone; the call sites revert to plain asyncio.gather. Also: - Reject bool in max_concurrency validation (bool is an int subclass, so set_max_concurrency(True) / IndexConfig(max_concurrency=True) previously became Semaphore(1) and silently serialized). Shared _validate_max_concurrency + a pydantic field_validator. - Guard check_title_appearance_in_start_concurrent against an out-of-range or 0 physical_index (LLM can emit one): it was dereferenced during task construction, outside the gather's return_exceptions protection, aborting the whole build; 0 silently wrapped to the last page. Now marked 'no'. - Propagate contextvars into agent.py's worker-thread run (mirrors pipeline._run_async) so ContextVar settings stay consistent. - Tests rewritten to cover the nested case the old flat tests missed, the leaf-level throttle in llm_acompletion, bool rejection, and the out-of-range physical_index guard. Claude-Session: https://claude.ai/code/session_01Kx5DgKbhK1N8autqXH8SmS
2026-07-08 11:26:36 +08:00
def test_check_title_appearance_tolerates_out_of_range_physical_index():
"""An LLM-emitted physical_index outside page_list must be marked 'no', not
raise IndexError (which happens during task construction, outside the
gather's return_exceptions protection, and would abort the whole build)."""
from pageindex.index.page_index import check_title_appearance_in_start_concurrent
page_list = [("only page text", 3)] # length 1
structure = [
{"title": "A", "physical_index": 5}, # out of range -> would IndexError
{"title": "B", "physical_index": 0}, # 0 -> would wrap to page_list[-1]
{"title": "C", "physical_index": None}, # missing
{"title": "D"}, # no physical_index key at all
]
result = asyncio.run(
check_title_appearance_in_start_concurrent(structure, page_list)
)
assert all(item["appear_start"] == "no" for item in result)