From decde3290bd164a31e3931f7dfc1227323cbc857 Mon Sep 17 00:00:00 2001
From: geekan <geekan@foxmail.com>
Date: Thu, 11 Jan 2024 15:54:18 +0800
Subject: [PATCH] simplify llm usage

---
 metagpt/context.py | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/metagpt/context.py b/metagpt/context.py
index 663c1730a..377744046 100644
--- a/metagpt/context.py
+++ b/metagpt/context.py
@@ -103,7 +103,6 @@ class ContextMixin(BaseModel):
     _config: Optional[Config] = None
 
     # Env/Role/Action will use this llm as private llm, or use self.context._llm instance
-    _llm_config: Optional[LLMConfig] = None
     _llm: Optional[BaseLLM] = None
 
     def __init__(
@@ -132,10 +131,6 @@ class ContextMixin(BaseModel):
         """Set config"""
         self.set("_config", config, override)
 
-    def set_llm_config(self, llm_config: LLMConfig, override=False):
-        """Set llm config"""
-        self.set("_llm_config", llm_config, override)
-
     def set_llm(self, llm: BaseLLM, override=False):
         """Set llm"""
         self.set("_llm", llm, override)
@@ -166,11 +161,11 @@ class ContextMixin(BaseModel):
 
     @property
     def llm(self) -> BaseLLM:
-        """Role llm: role llm > context llm"""
+        """Role llm: if not existed, init from role.config"""
         # print(f"class:{self.__class__.__name__}({self.name}), llm: {self._llm}, llm_config: {self._llm_config}")
-        if self._llm_config and not self._llm:
-            self._llm = self.context.llm_with_cost_manager_from_llm_config(self._llm_config)
-        return self._llm or self.context.llm()
+        if not self._llm:
+            self._llm = self.context.llm_with_cost_manager_from_llm_config(self.config.llm)
+        return self._llm
 
     @llm.setter
     def llm(self, llm: BaseLLM) -> None: