From d998a48cd2fc26bada36a46b87c60fe82c4ec821 Mon Sep 17 00:00:00 2001
From: stellahsr <stellahsr@126.com>
Date: Fri, 6 Oct 2023 16:37:52 +0800
Subject: [PATCH] update critic_agent use

---
 metagpt/roles/minecraft/action_developer.py | 4 ++--
 metagpt/roles/minecraft/critic_agent.py     | 2 +-
 minecraft_run.py                            | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/metagpt/roles/minecraft/action_developer.py b/metagpt/roles/minecraft/action_developer.py
index 9791d5b88..6a2ffd654 100644
--- a/metagpt/roles/minecraft/action_developer.py
+++ b/metagpt/roles/minecraft/action_developer.py
@@ -46,7 +46,7 @@ class ActionDeveloper(Base):
         self._watch([RetrieveSkills])
         self.rollout_num_iter = 0
         self.task_max_retries = 4
-        self.critic_reviewer = CriticReviewer()
+        self.critic_reviewer = agent_registry["critic_agent"]
     
     def render_system_message(self, skills=[], *args, **kwargs):
         """
@@ -190,7 +190,7 @@ class ActionDeveloper(Base):
     
     async def run_step(self, human_msg, system_msg, *args, **kwargs):
         while True:
-            messages, reward, done, info = self.runcode_and_evaluate(human_msg, system_msg, *args, **kwargs)
+            messages, reward, done, info = await self.runcode_and_evaluate(human_msg, system_msg, *args, **kwargs)
             if done:
                 break
         return messages, reward, done, info
diff --git a/metagpt/roles/minecraft/critic_agent.py b/metagpt/roles/minecraft/critic_agent.py
index d9c9db699..fb82c1cc7 100644
--- a/metagpt/roles/minecraft/critic_agent.py
+++ b/metagpt/roles/minecraft/critic_agent.py
@@ -33,7 +33,7 @@ class CriticReviewer(Base):
 
         # Set events or actions the CriticReviewer should watch or be aware of
         # 需要获取最新的events来进行评估
-        self._watch([GenerateActionCode, AddNewSkills])
+        self._watch([])
 
     async def run(self, message=None):
         """Observe, only get the observation"""
diff --git a/minecraft_run.py b/minecraft_run.py
index d0bcb5fd9..d7d2cf7c2 100644
--- a/minecraft_run.py
+++ b/minecraft_run.py
@@ -19,7 +19,7 @@ async def learn(task="Start", investment: float = 50.0, n_round: int = 3):
         [
             CurriculumDesigner(),
             ActionDeveloper(),
-            # CriticReviewer(),
+            CriticReviewer(),
             SkillManager(),
         
         ]