From d79fe56a38596385a6ea5aafdb5752942bbebedc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=8E=98=E6=9D=83=20=E9=A9=AC?= <mashenquan@fuzhi.ai>
Date: Fri, 28 Jul 2023 16:34:30 +0800
Subject: [PATCH] fixbug: prompt format error

---
 metagpt/actions/write_teaching_plan.py        | 60 +++++++++----------
 .../actions/test_write_teaching_plan.py       |  4 +-
 2 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/metagpt/actions/write_teaching_plan.py b/metagpt/actions/write_teaching_plan.py
index 370c70040..4c36983ff 100644
--- a/metagpt/actions/write_teaching_plan.py
+++ b/metagpt/actions/write_teaching_plan.py
@@ -75,13 +75,12 @@ class WriteTeachingPlanPart(Action):
         """Show `topic` value when debug"""
         return self.topic
 
-    FORMATION = """
-    \t\"Capacity and role\" defines the role you are currently playing;
-    \t\"[LESSON_BEGIN]\" and \"[LESSON_END]\" tags enclose the content of textbook;
-    \t\"Statement\" defines the work detail you need to complete at this stage;
-    \t\"Answer options\" defines the format requirements for your responses;
-    \t\"Constraint\" defines the conditions that your responses must comply with.
-    """
+    FORMATION = "\"Capacity and role\" defines the role you are currently playing;\n" \
+                "\t\"[LESSON_BEGIN]\" and \"[LESSON_END]\" tags enclose the content of textbook;\n" \
+                "\t\"Statement\" defines the work detail you need to complete at this stage;\n" \
+                "\t\"Answer options\" defines the format requirements for your responses;\n" \
+                "\t\"Constraint\" defines the conditions that your responses must comply with."
+
     COURSE_TITLE = "Title"
     TOPICS = [COURSE_TITLE, "Teaching Hours", "Teaching Objectives", "Teaching Content",
               "Teaching Methods and Strategies", "Learning Activities",
@@ -104,31 +103,32 @@ class WriteTeachingPlanPart(Action):
     }
 
     # Teaching plan title
-    PROMPT_TITLE_TEMPLATE = """
-        Do not refer to the context of the previous conversation records, start the conversation anew.\n\n
-        Formation: {formation}\n\n
-        {statements}\n
-        Constraint: Writing in {language}.\n
-        Answer options: Encloses the lesson title with "[TEACHING_PLAN_BEGIN]" and "[TEACHING_PLAN_END]" tags.\n
-        [LESSON_BEGIN]\n
-        {lesson}\n
-        [LESSON_END]
-        """
+    PROMPT_TITLE_TEMPLATE = "Do not refer to the context of the previous conversation records, " \
+                            "start the conversation anew.\n\n" \
+                            "Formation: {formation}\n\n" \
+                            "{statements}\n" \
+                            "Constraint: Writing in {language}.\n" \
+                            "Answer options: Encloses the lesson title with \"[TEACHING_PLAN_BEGIN]\" " \
+                            "and \"[TEACHING_PLAN_END]\" tags.\n" \
+                            "[LESSON_BEGIN]\n" \
+                            "{lesson}\n" \
+                            "[LESSON_END]"
 
     # Teaching plan parts:
-    PROMPT_TEMPLATE = """
-    Do not refer to the context of the previous conversation records, start the conversation anew.\n\n
-    Formation: {formation}\n\n
-    Capacity and role: {role}\n
-    Statement: Write the "{topic}" part of teaching plan, WITHOUT ANY content unrelated to "{topic}"!!\n
-    {statements}\n
-    Answer options: Enclose the teaching plan content with "[TEACHING_PLAN_BEGIN]" and "[TEACHING_PLAN_END]" tags.\n
-    Answer options: Using proper markdown format from second-level header format.\n
-    Constraint: Writing in {language}.\n
-    [LESSON_BEGIN]\n
-    {lesson}\n
-    [LESSON_END]
-    """
+    PROMPT_TEMPLATE = "Do not refer to the context of the previous conversation records, " \
+                      "start the conversation anew.\n\n" \
+                      "Formation: {formation}\n\n" \
+                      "Capacity and role: {role}\n" \
+                      "Statement: Write the \"{topic}\" part of teaching plan, " \
+                      "WITHOUT ANY content unrelated to \"{topic}\"!!\n" \
+                      "{statements}\n" \
+                      "Answer options: Enclose the teaching plan content with \"[TEACHING_PLAN_BEGIN]\" " \
+                      "and \"[TEACHING_PLAN_END]\" tags.\n" \
+                      "Answer options: Using proper markdown format from second-level header format.\n" \
+                      "Constraint: Writing in {language}.\n" \
+                      "[LESSON_BEGIN]\n" \
+                      "{lesson}\n" \
+                      "[LESSON_END]"
 
     DATA_BEGIN_TAG = "[TEACHING_PLAN_BEGIN]"
     DATA_END_TAG = "[TEACHING_PLAN_END]"
diff --git a/tests/metagpt/actions/test_write_teaching_plan.py b/tests/metagpt/actions/test_write_teaching_plan.py
index 2e34491fb..299a89639 100644
--- a/tests/metagpt/actions/test_write_teaching_plan.py
+++ b/tests/metagpt/actions/test_write_teaching_plan.py
@@ -34,7 +34,7 @@ async def mock_write_teaching_plan_part():
         {
             "input": "AABBCC",
             "name": "A",
-            "topic": "B",
+            "topic": WriteTeachingPlanPart.COURSE_TITLE,
             "language": "C"
         },
         {
@@ -52,7 +52,7 @@ async def mock_write_teaching_plan_part():
         assert act.topic == seed.topic
         assert str(act) == seed.topic
         assert act.name == seed.name
-        assert act.rsp == "prompt"
+        assert act.rsp == "# prompt" if seed.topic == WriteTeachingPlanPart.COURSE_TITLE else "prompt"
 
 
 def test_suite():