Minecraft game add skill_manager & ignore bug fix

metagpt/actions/minecraft/design_curriculumn.py

@@ -101,20 +101,19 @@ class DesignCurriculum(Action):
         # TODO: change to FaissStore
         # self.qa_cache_questions_vectordb = FaissStore( {CKPT_DIR}/ 'curriculum/vectordb')
 
-        # Check if qa_cache right using
-        assert self.qa_cache_questions_vectordb._collection.count() == len(
-            self.qa_cache
-        ), (
-            f"Curriculum Agent's qa cache question vectordb is not synced with qa_cache.json.\n"
-            f"There are {self.qa_cache_questions_vectordb._collection.count()} questions in vectordb "
-            f"but {len(self.qa_cache)} questions in qa_cache.json.\n"
-            f"Did you set resume=False when initializing the agent?\n"
-            f"You may need to manually delete the qa cache question vectordb directory for running from scratch.\n"
-        )
-
     @classmethod
     def set_qa_cache(cls, qa_cache):
         cls.qa_cache = qa_cache
+        # Check if qa_cache right using
+        assert cls.qa_cache_questions_vectordb._collection.count() == len(
+            cls.qa_cache
+        ), (
+            f"Curriculum Agent's qa cache question vectordb is not synced with qa_cache.json.\n"
+            f"There are {cls.qa_cache_questions_vectordb._collection.count()} questions in vectordb "
+            f"but {len(cls.qa_cache)} questions in qa_cache.json.\n"
+            f"Did you set resume=False when initializing the agent?\n"
+            f"You may need to manually delete the qa cache question vectordb directory for running from scratch.\n"
+        )
 
     @classmethod
     def generate_qa(cls, events, chest_observation):

metagpt/actions/minecraft/generate_actions.py

@@ -27,20 +27,23 @@ class GenerateActionCode(Action):
         # logger.info(f"parsed_result is HERE: {parsed_result}")
 
         try:
-            return parsed_result["program_code"] + "\n" + parsed_result["exec_code"]
+            return (
+                parsed_result["program_code"] + "\n" + parsed_result["exec_code"],
+                parsed_result["program_name"],
+            )
         except:
             logger.error(f"Failed to parse response: {parsed_result}")
-            return None
+            return None, None
 
     async def run(self, human_msg, system_msg, *args, **kwargs):
         logger.info(f"run {self.__repr__()}")
         # Generate action code.
-        generated_code = await self.generate_code(
+        generated_code, program_name = await self.generate_code(
             human_msg=human_msg, system_msg=system_msg
         )
 
         # Return the generated code.
-        return generated_code
+        return generated_code, program_name
 
 
 class SummarizeLog(Action):

metagpt/actions/minecraft/manage_skills.py

@@ -2,9 +2,15 @@
 # @Date    : 2023/9/23 14:56
 # @Author  : stellahong (stellahong@fuzhi.ai)
 # @Desc    :
+import os
+import json
 
+from langchain.embeddings.openai import OpenAIEmbeddings
+from langchain.vectorstores import Chroma
+from metagpt.document_store import FaissStore
 from metagpt.logs import logger
 from metagpt.actions import Action
+from metagpt.const import CKPT_DIR
 
 
 class RetrieveSkills(Action):
@@ -12,14 +18,44 @@ class RetrieveSkills(Action):
     Action class for retrieving skills.
     Refer to the code in the voyager/agents/skill.py for implementation details.
     """
-    
+
     def __init__(self, name="", context=None, llm=None):
         super().__init__(name, context, llm)
-        self.vect_db = ""
-    
-    async def run(self, *args, **kwargs):
+        # TODO: mv to PlayerAction
+        self.retrieval_top_k = 5
+        self.skills = {}
+        self.vectordb = Chroma(
+            collection_name="skill_vectordb",
+            embedding_function=OpenAIEmbeddings(),
+            persist_directory=f"{CKPT_DIR}/skill/vectordb",
+        )
+
+    @classmethod
+    def set_skills(cls, skills):
+        cls.skills = skills
+        # Check if skills right using
+        assert cls.vectordb._collection.count() == len(cls.skills), (
+            f"Skill Manager's vectordb is not synced with skills.json.\n"
+            f"There are {cls.vectordb._collection.count()} skills in vectordb but {len(cls.skills)} skills in skills.json.\n"
+            f"Did you set resume=False when initializing the manager?\n"
+            f"You may need to manually delete the vectordb directory for running from scratch."
+        )
+
+    async def run(self, query, *args, **kwargs):
         # Implement the logic for retrieving skills here.
-        return []
+        k = min(self.vectordb._collection.count(), self.retrieval_top_k)
+        if k == 0:
+            return []
+        logger.info(f"Skill Manager retrieving for {k} skills")
+        docs_and_scores = self.vectordb.similarity_search_with_score(query, k=k)
+        logger.info(
+            f"Skill Manager retrieved skills: "
+            f"{', '.join([doc.metadata['name'] for doc, _ in docs_and_scores])}"
+        )
+        skills = []
+        for doc, _ in docs_and_scores:
+            skills.append(self.skills[doc.metadata["name"]]["code"])
+        return skills
 
 
 class AddNewSkills(Action):
@@ -27,13 +63,71 @@ class AddNewSkills(Action):
     Action class for adding new skills.
     Refer to the code in the voyager/agents/skill.py for implementation details.
     """
-    
+
     def __init__(self, name="", context=None, llm=None):
         super().__init__(name, context, llm)
-    
-    async def run(self, *args, **kwargs):
+        # TODO: mv to PlayerAction
+        self.vectordb = Chroma(
+            collection_name="skill_vectordb",
+            embedding_function=OpenAIEmbeddings(),
+            persist_directory=f"{CKPT_DIR}/skill/vectordb",
+        )
+        # TODO: change to FaissStore
+        # self.qa_cache_questions_vectordb = FaissStore( {CKPT_DIR}/ 'skill/vectordb')
+
+    @classmethod
+    def set_skills(cls, skills):
+        cls.skills = skills
+        # Check if skills right using
+        assert cls.vectordb._collection.count() == len(cls.skills), (
+            f"Skill Manager's vectordb is not synced with skills.json.\n"
+            f"There are {cls.vectordb._collection.count()} skills in vectordb but {len(cls.skills)} skills in skills.json.\n"
+            f"Did you set resume=False when initializing the manager?\n"
+            f"You may need to manually delete the vectordb directory for running from scratch."
+        )
+
+    async def run(
+        self, task, program_name, program_code, skills, skill_desp, *args, **kwargs
+    ):
         # Implement the logic for adding new skills here.
-        pass
+        if task.startswith("Deposit useless items into the chest at"):
+            # No need to reuse the deposit skill
+            return {}
+        # TODO: Fix this
+        logger.info(
+            f"Skill Manager generated description for {program_name}:\n{skill_desp}\033[0m"
+        )
+        if program_name in skills:
+            logger.info(f"Skill {program_name} already exists. Rewriting!")
+            self.vectordb._collection.delete(ids=[program_name])
+            i = 2
+            while f"{program_name}V{i}.js" in os.listdir(f"{CKPT_DIR}/skill/code"):
+                i += 1
+            dumped_program_name = f"{program_name}V{i}"
+        else:
+            dumped_program_name = program_name
+        self.vectordb.add_texts(
+            texts=[skill_desp],
+            ids=[program_name],
+            metadatas=[{"name": program_name}],
+        )
+
+        # FIXME
+        # assert self.vectordb._collection.count() == len(
+        #     skills
+        # ), "vectordb is not synced with skills.json"
+
+        with open(f"{CKPT_DIR}/skill/code/{dumped_program_name}.js", "w") as f:
+            f.write(program_code)
+        with open(f"{CKPT_DIR}/skill/description/{dumped_program_name}.txt", "w") as f:
+            f.write(skill_desp)
+        with open(f"{CKPT_DIR}/skill/skills.json", "w") as f:
+            json.dump(skills, f)
+        self.vectordb.persist()
+        return {
+            "code": program_code,
+            "description": skill_desp,
+        }
 
 
 class GenerateSkillDescription(Action):
@@ -41,13 +135,12 @@ class GenerateSkillDescription(Action):
     Action class for generating skill descriptions.
     Refer to the code in the voyager/agents/skill.py for implementation details.
     """
-    
+
     def __init__(self, name="", context=None, llm=None):
         super().__init__(name, context, llm)
-    
-    async def run(self, *args, **kwargs):
-        # Implement the logic for generating skill descriptions here.
-        pass
 
-    
-    
+    async def run(self, program_name, human_message, system_message, *args, **kwargs):
+        # Implement the logic for generating skill descriptions here.
+        rsp = await self._aask(prompt=human_message, system_msgs=system_message)
+        skill_description = f"    // { rsp}"
+        return f"async function {program_name}(bot) {{\n{skill_description}\n}}"